1660 tests for sload and sstore where one of these instructions has multiple revert reasons #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne-of-these-instructions-has-multiple-revert-reasons
|
Hey @lorenzogentile404 , the original issue describes the case where it's always the same smart contract whose storage changes. I.e. it's performing self calls. From what I saw on our calls the tests don't directly address the issue. We can definitively keep the We should implement two versions
Where whether a revert takes place depends on e.g. the parity of the integer in call data. |
…ne-of-these-instructions-has-multiple-revert-reasons
…ne-of-these-instructions-has-multiple-revert-reasons
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.