-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ephemery config url and remove hardcoded config file #9155
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: gconnect <[email protected]>
@rolfyone please review when you have the time. |
ethereum/spec/src/main/java/tech/pegasys/teku/spec/config/SpecConfigLoader.java
Fixed
Show resolved
Hide resolved
Thanks for raising the PR, I'll take a look. |
I think the latest url has all the numbers right so really, we'd want to clean up a lot of what's currently done in 'ephemery' for updating config, we shouldn't need it any more. |
When working on this PR, I figured since we are able to access the config directly from the internet that we might not need those custom ephemery class and method that handle the update. So I think if I remove the ephemery class it should still work as expected. As for the location of this PR I think this might potentially be the place where the config URL should be called as I was able to run it and it worked as expected. I think I just have to modify the deprecated function. |
…ot import in EphemeryValidationService and test file Signed-off-by: gconnect <[email protected]>
will look at this as soon as holesky incident calms down - sorry.. just fyi |
Alright no problem thanks. I will be looking forward to your review when you have the time. |
PR Description
Fixed Issue(s)
fixes #9121
Documentation
doc-change-required
label to this PR if updates are required.Changelog