-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FC validate_inclusion_lists #9159
base: focil
Are you sure you want to change the base?
FC validate_inclusion_lists #9159
Conversation
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
...m/statetransition/src/main/java/tech/pegasys/teku/statetransition/forkchoice/ForkChoice.java
Outdated
Show resolved
Hide resolved
...m/statetransition/src/main/java/tech/pegasys/teku/statetransition/forkchoice/ForkChoice.java
Outdated
Show resolved
Hide resolved
...m/statetransition/src/main/java/tech/pegasys/teku/statetransition/forkchoice/ForkChoice.java
Outdated
Show resolved
Hide resolved
Yes this check will be performed when we import a block on slot N+1. We check that the ILs we've collected from the p2p network are included in the new block's execution payload.
|
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I guess we can merge it for now ans keep an eye on the spec since we'd need to check if any missing transaction is invalid by calling the EL but it's not clear yet how we will do that.
PR Description
This PR add the implementation of
validate_inclusion_lists
to fork choice. Although it's not being used yet, this is rather a useful to check to have and to perform up on block import.Fixed Issue(s)
Fixes #9097
Documentation
doc-change-required
label to this PR if updates are required.Changelog