Ignore aggregate if falling behind #9190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if we're falling behind and receive an aggregate we attempt to validate it but our state is too old in some circumstances. We can't validate this aggregate, but currently we're rejecting it, which is worse than ignoring it for gossip rules, so we're better off just ignoring it. fixes Consensys#9187 Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
gfukushima
reviewed
Mar 3, 2025
| @@ -174,14 +176,18 @@ SafeFuture<InternalValidationResultWithState> singleOrAggregateAttestationChecks | |||
|
|
|||
| if (!attestation.isSingleAttestation()) { | |||
| // [REJECT] The number of aggregation bits matches the committee size | |||
There was a problem hiding this comment.
I'd take the opportunity here to move the comment to the if check so it continues to matche what the code is doing.
There was a problem hiding this comment.
but this whole block only does that... i was just making it not go boom... not sure it'll be v. clear if its down 2 levels?
gfukushima
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if we're falling behind and receive an aggregate we attempt to validate it but our state is too old in some circumstances.
We can't validate this aggregate, but currently we're rejecting it, which is worse than ignoring it for gossip rules, so we're better off just ignoring it.
fixes #9187
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog