Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit weight to max_uint64 to avoid overflow #9191

Merged
merged 4 commits into from
Mar 3, 2025

Conversation

rolfyone
Copy link
Contributor

@rolfyone rolfyone commented Mar 3, 2025

fixes #9189

could be worked to larger value if we need? but this seems like a hard thing to get to currently...

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

rolfyone added 2 commits March 3, 2025 13:59
fixes Consensys#9189

could be worked to larger value if we need? but this seems like a hard thing to get to currently...

Signed-off-by: Paul Harris <[email protected]>
Copy link
Member

@lucassaldanha lucassaldanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT. Added a suggestion for a reusable option on Uint64

@rolfyone rolfyone merged commit 690517e into Consensys:master Mar 3, 2025
16 checks passed
@rolfyone rolfyone deleted the 9178 branch March 3, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HOLESKY PECTRA] ArithmeticException! FCU
2 participants