Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FavoriteButton) fix favorite button funtionality on tool page #1368

Merged

Conversation

gitmotion
Copy link
Contributor

@gitmotion gitmotion commented Oct 25, 2024

@CorentinTh
Bug Fix: #1365
before and after:
beforeafterdemo

- previously was not passing the route path to the object when passing as tool:
toollayoutonlypassesname
frompageonlypassesname

- this also caused it to add nulls to the favoritesToolName in local storage:
addsnull

- adding the path should prevent nulls from getting added now but also added if check before adding directly to the store:
after change

Copy link

vercel bot commented Oct 25, 2024

@gitmotion is attempting to deploy a commit to the Corentin Thomasset's Team Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@gitmotion gitmotion changed the title feat(FavoriteButton) fix favorite button funtionality on tool page fix(FavoriteButton) fix favorite button funtionality on tool page Oct 25, 2024
Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
it-tools ✅ Ready (Inspect) Visit Preview Oct 25, 2024 4:27pm

Copy link
Owner

@CorentinTh CorentinTh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the fix 🙏

@CorentinTh CorentinTh enabled auto-merge (squash) October 25, 2024 16:26
@CorentinTh CorentinTh merged commit ae13639 into CorentinTh:main Oct 25, 2024
7 checks passed
dragonoasis added a commit to dragonoasis/it-tools that referenced this pull request Jan 12, 2025
* feat(new-tool): added unicode conversion utilities (CorentinTh#858)

* feat: add Text to Unicode tool

* Update src/tools/text-to-unicode/index.ts

---------

Co-authored-by: Corentin THOMASSET <[email protected]>

* feat(new-tool): yaml formater (CorentinTh#779)

* validating if yaml is correct and collecting format options

* Formatting yaml, sorting keys and changing indent size.

* Removed unused format options

* Fixed lint errors

* Installed types for js-yaml

* Removed legacy routing and added tool creation date

Co-authored-by: Corentin THOMASSET <[email protected]>

* Using existing yaml package instead of js-yaml

* Update src/tools/yaml-viewer/index.ts

---------

Co-authored-by: Isaiah <[email protected]>
Co-authored-by: Corentin THOMASSET <[email protected]>

* feat(i18n): added ukrainian language (CorentinTh#827)

Added Ukrainian language

* feat(i18n): added portuguese language (CorentinTh#813)

* feat(i18n): added spanish language (CorentinTh#854)

* spanish

translation

* Create es.yaml

* refactor(i18n): added locales per tool (CorentinTh#861)

* feat(i18n): added vietnamese language (CorentinTh#859)

* feat(i18n): added missing locale files in tools (CorentinTh#863)

* feat(i18n): added zh tools translations (CorentinTh#874)

* feat(i18n): added vi tools translations (CorentinTh#876)

* Update Vietnamese translations in vi.yml file

* Add Vietnamese translations for various tools

* feat(i18n): get locales on build (CorentinTh#880)

* refactor(home): removed n-grid to prevent layout shift (CorentinTh#881)

* refactor(home): lightened tool cards (CorentinTh#882)

* feat(new tool): ascii art generator (CorentinTh#886)

* feat(new tool): ascii art generator

Fix CorentinTh#829 ; Text ASCII Art Generator (using figlet)

* fix: make fonts list searchable

* refactor(ascii-generator): updated tool definition

* refactor(ascii-generator): equilibrate ui

---------

Co-authored-by: Corentin Thomasset <[email protected]>

* feat(new tool): Outlook Safelink Decoder (CorentinTh#911)

* feat(new tool): Outlook Safelink Decoder

Fix CorentinTh#897

* Use native URL parsing

Co-authored-by: Corentin THOMASSET <[email protected]>

* Update src/tools/safelink-decoder/index.ts

---------

Co-authored-by: Corentin THOMASSET <[email protected]>

* fix(bcrypt tool): allow salt rounds up to 100 (CorentinTh#987)

* fix(bcrypt tool): allow salt rounds up to 100

Previously max salt rounds was 10

* chore(github workflows): ci and e2e tests: try updating to node 20

* fix(integer base converter): support bigint (CorentinTh#872)

* fix(url-encoder, validation): typo in validation of url-encoder.vue CorentinTh#1024

* fix(language): English language cleanup (CorentinTh#1036)

Fix possessive vs. contraction form of "it," clarification, and some general cleanup

* feat(i18n): added German translation (CorentinTh#1038)

* feat(i18n): German translation

* more

* more

* more

* rest

* chore(issues): improved bug issue template (CorentinTh#1046)

* refactor(auto-imports): regen auto imports

* chore(issues): improved issues template

* refactor(lint): removed extra semi

* docs(changelog): update changelog for 2024.05.10-33e5294

* chore(version): release 2024.05.10-33e5294

* chore(node): upgraded node version in CI workflows

* chore(issues): removed old issue templates (CorentinTh#1077)

* chore(issues): prevent empty issues (CorentinTh#1078)

* docs(changelog): update changelog for 2024.05.13-a0bc346

* chore(version): release 2024.05.13-a0bc346

* feat(base64): Base64 enhancements (CorentinTh#905)

* fix(base64): use js-base64 to handle non ascii text

Use js-base64 to handle non ascii text and ignore whitespaces
Fix CorentinTh#879 and CorentinTh#409

* fix(base64): use js-base64 to handle non ascii text

Use js-base64 to handle non ascii text and ignore whitespaces
Fix CorentinTh#879 and CorentinTh#409

* feat(base64 file converter): add a filename and extension fields

Add filename and extension (auto filled if data url) to allow downloading with right extension and filename
Fix CorentinTh#788

* feat(base64 file converter): add a preview image

Fix CorentinTh#594. Taken from CorentinTh#595 (thanks @SAF2k)

* fix(jwt-parser): prevent UI overflow on small screen (CorentinTh#1095)

Fix CorentinTh#1045

* fix(format-transformer): set overflow for output area width (CorentinTh#787)

* fix(emoji-picker): debounced search input (CorentinTh#1181)

* fix(Emoji picker): fix lags

Fix CorentinTh#1176 using debounced ref

* chore: fix strange corepack message

Fix corepack claiming strange thing : UsageError: This project is configured to use yarn because /home/runner/work/it-tools/it-tools/package.json has a "packageManager" field

* feat(lorem-ipsum): add button to refresh text lorem-ipsum (CorentinTh#1213)

Co-authored-by: Diego Guzmán <[email protected]>

* feat(new tools): JSON to XML and XML to JSON (CorentinTh#1231)

* feat(new tool): JSON <> XML

Fix CorentinTh#314

* Update src/tools/xml-to-json/index.ts

* Update src/tools/json-to-xml/index.ts

* Update src/tools/json-to-xml/index.ts

---------

Co-authored-by: Corentin THOMASSET <[email protected]>

* feat(new-tool): add email normalizer (CorentinTh#1243)

* feat(new tool): Markdown to HTML (CorentinTh#916)

* feat(new tool): Markdown to HTML

Fix partially CorentinTh#538

* feat: add print button

* Update src/tools/markdown-to-html/index.ts

* Update src/tools/markdown-to-html/markdown-to-html.vue

---------

Co-authored-by: Corentin THOMASSET <[email protected]>

* chore(readme): updated logos (CorentinTh#1294)

* feat(new tool): Regex Tester (and Cheatsheet) (CorentinTh#1030)

* feat(new tool): Regex Tester

Fix CorentinTh#1007, CorentinTh#991, CorentinTh#936, CorentinTh#761, CorentinTh#649
CorentinTh#644, CorentinTh#554
CorentinTh#308

* fix: refactor to service + add regex diagram + ui enhancements

* fix: update queryParams

* fix: deps

* fix: svg style bug in @regexper/render

@regexper/render use a stylesheet in svg that cause bugs in whole site. So add regexper in a shadow root

* feat(new tool): added Regex Cheatsheet

* Update src/tools/regex-memo/index.ts

* Update src/tools/regex-tester/index.ts

---------

Co-authored-by: Corentin THOMASSET <[email protected]>

* refactor(regex-tester): better description

* docs(author): updated author links (CorentinTh#1316)

* chore(sponsors): fern sponsor banners (CorentinTh#1314)

* chore(sponsors): readme banner

* chore(sponsors): app sponsor

* fix(favorites): store favorites regardless of languages (CorentinTh#1202)

Fix CorentinTh#1110

* docs(changelog): update changelog for 2024.10.22-7ca5933

* chore(version): release 2024.10.22-7ca5933

* feat(i18n): added Norwegian language (CorentinTh#1337)

* fix(yaml-to-json): allow merge key to be parsed (CorentinTh#1359)

* fix(yaml-to-json): allow merge key to be parsed

* correct e2e tests

---------

Co-authored-by: lvluu <[email protected]>

* feat(html-wysiwyg-editor) h3 fix (CorentinTh#1363)

* fix(readme): refresh stale contributors graph (CorentinTh#1364)

* fix(FavoriteButton): pass tool path to favorite button (CorentinTh#1368)

* fix(icons,branding): swap twitter to X (CorentinTh#1369)

* feat(favorites) drag-and-drop favorites section (CorentinTh#1360)

* refactor(sponsor): removed sponsor banner and related configurations (CorentinTh#1405)

* fix(locales): update license from MIT to GPL-3.0 in language files (CorentinTh#1419)

* feat(sponsor): added sponsor banner (CorentinTh#1422)

* More cleanup and bug fixing

* update pnpm-lock.yaml file

* fix build break

* Revert previous change and fix build break

* Fix CI/CD pipeline error

* minor update to fix test case failure

---------

Co-authored-by: hieudt-2054 <[email protected]>
Co-authored-by: Corentin THOMASSET <[email protected]>
Co-authored-by: Isaiah <[email protected]>
Co-authored-by: Isaiah <[email protected]>
Co-authored-by: Nikitin Roman <[email protected]>
Co-authored-by: Marcelo Gonçalves <[email protected]>
Co-authored-by: Raúl Mora <[email protected]>
Co-authored-by: QingFeng <[email protected]>
Co-authored-by: David Nguyen <[email protected]>
Co-authored-by: sharevb <[email protected]>
Co-authored-by: Pavel Gordon <[email protected]>
Co-authored-by: Christopher Conley <[email protected]>
Co-authored-by: steffenrapp <[email protected]>
Co-authored-by: code2933 <[email protected]>
Co-authored-by: Diego Fabricio <[email protected]>
Co-authored-by: Diego Guzmán <[email protected]>
Co-authored-by: Knu753n <[email protected]>
Co-authored-by: Luu Van Loi <[email protected]>
Co-authored-by: lvluu <[email protected]>
Co-authored-by: gitmotion <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Favorite Button Not working on a tool
2 participants