Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): improve chinese i18n #786

Closed
wants to merge 2 commits into from
Closed

Conversation

likonion
Copy link

Added Chinese tools name and description

Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
it-tools ✅ Ready (Inspect) Visit Preview Nov 30, 2023 2:50am

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@YoungerYang-Y
Copy link

Will it be included in the next release?

@@ -56,6 +56,8 @@ toolCard:
new: '新'
search:
label: '搜索'
transition:
placeholder: '请输入工具名或者命令……'
Copy link

@K6F K6F Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I'm a new user of it-tools and I had the idea to add more translations of it before I found your excellent work.

I reviewed your change. It's a wonderful idea to move the placeholder of the popup search input box into the locale file. But also, I do realize that this translation is newly added, and doesn't exist in other language yml files under the locales folder.

Please also add this key in other language files, so this PR won't break the function for other languages.

@lqs1920
Copy link

lqs1920 commented Feb 4, 2024

Hi @likonion
我看了一下你改的中文版,标题和描述都改过来了,非常棒,我想了解下对应工具详情页面的中文也是可以改的吗

@likonion likonion closed this Feb 29, 2024
@likonion likonion deleted the zh branch January 16, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants