Skip to content

Commit

Permalink
Upgrade JDK to 11 in actions
Browse files Browse the repository at this point in the history
  • Loading branch information
chetangudisagar committed May 4, 2024
1 parent 880e670 commit 651ed4a
Show file tree
Hide file tree
Showing 12 changed files with 41 additions and 10 deletions.
5 changes: 4 additions & 1 deletion .github/workflows/publish-universe-artifacts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@ jobs:
- name: Set up JDK
uses: actions/setup-java@v1
with:
java-version: 1.8
distribution: 'corretto'
java-version: '11'
check-latest: true
cache-dependency-path: '**/pom.xml'

- name: Cache local Gradle repository
uses: actions/cache@v2
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/pull_request_benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,12 @@ jobs:
- uses: actions/checkout@v2

- name: Set up JDK
uses: actions/setup-java@v1
uses: actions/setup-java@v4
with:
java-version: 1.8
distribution: 'corretto'
java-version: '11'
check-latest: true
cache-dependency-path: '**/pom.xml'

- name: Cache local Gradle repository
uses: actions/cache@v2
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/pull_request_universe.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@ jobs:
- name: Set up JDK
uses: actions/setup-java@v1
with:
java-version: 1.8
distribution: 'corretto'
java-version: '11'
check-latest: true
cache-dependency-path: '**/pom.xml'

- name: Cache local Gradle repository
uses: actions/cache@v2
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/run_benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@ jobs:
- name: Set up JDK
uses: actions/setup-java@v1
with:
java-version: 1.8
distribution: 'corretto'
java-version: '11'
check-latest: true
cache-dependency-path: '**/pom.xml'

- name: Cache local Gradle repository
uses: actions/cache@v2
Expand Down
4 changes: 2 additions & 2 deletions benchmarks/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ apply(from = "${gradleScriptsDir}/gradle/idea.gradle")
version = "1.0.0"

val corfuVersion = project.ext["corfuVersion"] as String
val nettyVersion = project.ext["nettyVersion"] as String
val nettyTcnativeVersion = project.ext["nettyTcnativeVersion"] as String
val assertjVersion = project.ext["assertjVersion"] as String
val lombokVersion = project.ext["lombokVersion"] as String
val jmhSdkVersion = project.ext["jmhVersion"] as String
Expand All @@ -57,7 +57,7 @@ dependencies {
implementation("org.corfudb:runtime:${corfuVersion}") {
exclude(group = "io.netty", module = "netty-tcnative")
}
implementation("io.netty:netty-tcnative:${nettyVersion}:${osdetector.os}-${osdetector.arch}")
implementation("io.netty:netty-tcnative:${nettyTcnativeVersion}:${osdetector.os}-${osdetector.arch}")

jmh("org.openjdk.jmh:jmh-core:${jmhSdkVersion}")
jmh("org.openjdk.jmh:jmh-generator-annprocess:${jmhSdkVersion}")
Expand Down
3 changes: 3 additions & 0 deletions benchmarks/config/checkstyle/checkstyle.xml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
<property name="fileExtensions" value="java"/>
<property name="max" value="120"/>
<property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
<property name="severity" value="ignore"/>
</module>

<module name="TreeWalker">
Expand Down Expand Up @@ -287,12 +288,14 @@
<property name="allowMissingReturnTag" value="true"/>
<property name="allowedAnnotations" value="Override, Test"/>
<property name="tokens" value="METHOD_DEF, CTOR_DEF, ANNOTATION_FIELD_DEF"/>
<property name="severity" value="ignore"/>
</module>
<module name="MissingJavadocMethod">
<property name="scope" value="public"/>
<property name="minLineCount" value="2"/>
<property name="allowedAnnotations" value="Override, Test"/>
<property name="tokens" value="METHOD_DEF, CTOR_DEF, ANNOTATION_FIELD_DEF"/>
<property name="severity" value="ignore"/>
</module>
<module name="MethodName">
<property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9_]*$"/>
Expand Down
4 changes: 4 additions & 0 deletions cloud/infrastructure/config/checkstyle/checkstyle.xml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
<property name="fileExtensions" value="java"/>
<property name="max" value="120"/>
<property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
<property name="severity" value="ignore"/>
</module>

<module name="TreeWalker">
Expand Down Expand Up @@ -287,12 +288,14 @@
<property name="allowMissingReturnTag" value="true"/>
<property name="allowedAnnotations" value="Override, Test"/>
<property name="tokens" value="METHOD_DEF, CTOR_DEF, ANNOTATION_FIELD_DEF"/>
<property name="severity" value="ignore"/>
</module>
<module name="MissingJavadocMethod">
<property name="scope" value="public"/>
<property name="minLineCount" value="2"/>
<property name="allowedAnnotations" value="Override, Test"/>
<property name="tokens" value="METHOD_DEF, CTOR_DEF, ANNOTATION_FIELD_DEF"/>
<property name="severity" value="ignore"/>
</module>
<module name="MethodName">
<property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9_]*$"/>
Expand All @@ -301,6 +304,7 @@
</module>
<module name="SingleLineJavadoc">
<property name="ignoreInlineTags" value="false"/>
<property name="severity" value="ignore"/>
</module>
<module name="EmptyCatchBlock">
<property name="exceptionVariableName" value="expected"/>
Expand Down
4 changes: 4 additions & 0 deletions config/checkstyle/checkstyle.xml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
<property name="fileExtensions" value="java"/>
<property name="max" value="120"/>
<property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
<property name="severity" value="ignore"/>
</module>

<module name="TreeWalker">
Expand Down Expand Up @@ -287,12 +288,14 @@
<property name="allowMissingReturnTag" value="true"/>
<property name="allowedAnnotations" value="Override, Test"/>
<property name="tokens" value="METHOD_DEF, CTOR_DEF, ANNOTATION_FIELD_DEF"/>
<property name="severity" value="ignore"/>
</module>
<module name="MissingJavadocMethod">
<property name="scope" value="public"/>
<property name="minLineCount" value="2"/>
<property name="allowedAnnotations" value="Override, Test"/>
<property name="tokens" value="METHOD_DEF, CTOR_DEF, ANNOTATION_FIELD_DEF"/>
<property name="severity" value="ignore"/>
</module>
<module name="MethodName">
<property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9_]*$"/>
Expand All @@ -301,6 +304,7 @@
</module>
<module name="SingleLineJavadoc">
<property name="ignoreInlineTags" value="false"/>
<property name="severity" value="ignore"/>
</module>
<module name="EmptyCatchBlock">
<property name="exceptionVariableName" value="expected"/>
Expand Down
2 changes: 1 addition & 1 deletion gradle/dependencies.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ ext {
logbackVersion = "1.2.3"
corfuVersion = "0.4.2.1-SNAPSHOT"
protobufVersion = "3.11.1"
nettyVersion = "2.0.25.Final"
nettyTcnativeVersion = "2.0.60.Final"
assertjVersion = "3.14.0"
junitVersion = "5.5.2"
lombokVersion = "1.18.18"
Expand Down
4 changes: 2 additions & 2 deletions tests/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ apply(from="${gradleScriptsDir}/gradle/idea.gradle")
version = "1.0.0"

val corfuVersion = project.ext["corfuVersion"]
val nettyVersion = project.ext["nettyVersion"]
val nettyTcnativeVersion = project.ext["nettyTcnativeVersion"]
val assertjVersion = project.ext["assertjVersion"]
val lombokVersion = project.ext["lombokVersion"]

Expand Down Expand Up @@ -65,7 +65,7 @@ dependencies {
exclude(group="io.netty", module="netty-tcnative")
}

implementation("io.netty:netty-tcnative:${nettyVersion}:${osdetector.os}-${osdetector.arch}")
implementation("io.netty:netty-tcnative:${nettyTcnativeVersion}:${osdetector.os}-${osdetector.arch}")

implementation("org.assertj:assertj-core:${assertjVersion}")

Expand Down
4 changes: 4 additions & 0 deletions tests/config/checkstyle/checkstyle.xml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
<property name="fileExtensions" value="java"/>
<property name="max" value="120"/>
<property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
<property name="severity" value="ignore"/>
</module>

<module name="TreeWalker">
Expand Down Expand Up @@ -287,12 +288,14 @@
<property name="allowMissingReturnTag" value="true"/>
<property name="allowedAnnotations" value="Override, Test"/>
<property name="tokens" value="METHOD_DEF, CTOR_DEF, ANNOTATION_FIELD_DEF"/>
<property name="severity" value="ignore"/>
</module>
<module name="MissingJavadocMethod">
<property name="scope" value="public"/>
<property name="minLineCount" value="2"/>
<property name="allowedAnnotations" value="Override, Test"/>
<property name="tokens" value="METHOD_DEF, CTOR_DEF, ANNOTATION_FIELD_DEF"/>
<property name="severity" value="ignore"/>
</module>
<module name="MethodName">
<property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9_]*$"/>
Expand All @@ -301,6 +304,7 @@
</module>
<module name="SingleLineJavadoc">
<property name="ignoreInlineTags" value="false"/>
<property name="severity" value="ignore"/>
</module>
<module name="EmptyCatchBlock">
<property name="exceptionVariableName" value="expected"/>
Expand Down
4 changes: 4 additions & 0 deletions universe/config/checkstyle/checkstyle.xml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
<property name="fileExtensions" value="java"/>
<property name="max" value="120"/>
<property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
<property name="severity" value="ignore"/>
</module>

<module name="TreeWalker">
Expand Down Expand Up @@ -287,12 +288,14 @@
<property name="allowMissingReturnTag" value="true"/>
<property name="allowedAnnotations" value="Override, Test"/>
<property name="tokens" value="METHOD_DEF, CTOR_DEF, ANNOTATION_FIELD_DEF"/>
<property name="severity" value="ignore"/>
</module>
<module name="MissingJavadocMethod">
<property name="scope" value="public"/>
<property name="minLineCount" value="2"/>
<property name="allowedAnnotations" value="Override, Test"/>
<property name="tokens" value="METHOD_DEF, CTOR_DEF, ANNOTATION_FIELD_DEF"/>
<property name="severity" value="ignore"/>
</module>
<module name="MethodName">
<property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9_]*$"/>
Expand All @@ -301,6 +304,7 @@
</module>
<module name="SingleLineJavadoc">
<property name="ignoreInlineTags" value="false"/>
<property name="severity" value="ignore"/>
</module>
<module name="EmptyCatchBlock">
<property name="exceptionVariableName" value="expected"/>
Expand Down

0 comments on commit 651ed4a

Please sign in to comment.