Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release/2.2 #2275

Merged
merged 5 commits into from
Oct 7, 2024
Merged

Merge release/2.2 #2275

merged 5 commits into from
Oct 7, 2024

Conversation

chipshort
Copy link
Collaborator

Had to fix the CI and make cargo-release happy

Copy link
Member

@aumetra aumetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to transfer publishing permissions for cosmwasm-vm-derive :P

@aumetra
Copy link
Member

aumetra commented Oct 7, 2024

(re. the typos CI, I'd love to add an autofix run for it. Issue is that this will 100% at some point either correct to the wrong word or break test fixtures because they contain some Base64 that looks like garbled text to the tool)

Copy link
Contributor

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One extra comment to consider, but not necessary to be implemented

@@ -16,7 +16,7 @@ ark-bls12-381 = "0.4.0"
ark-ec = { version = "0.4.2", features = ["parallel"] }
ark-ff = { version = "0.4.2", features = ["asm", "parallel"] }
ark-serialize = "0.4.2"
cosmwasm-core = { version = "2.1.3", path = "../core" }
cosmwasm-core = { version = "2.2.0-rc.1", path = "../core" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: We can consider using [workspace.dependencies] section in the main Cargo.toml file for CW related crates

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair. We can do this separately and see if we encounter any problems. This PR is really just intended to get the changes I had to do for the 2.2-rc release into main.

@chipshort chipshort merged commit cc74d2c into main Oct 7, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants