Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App v2 update #1373

Draft
wants to merge 2 commits into
base: app_v2
Choose a base branch
from
Draft

App v2 update #1373

wants to merge 2 commits into from

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented May 2, 2023

See #1286

Blocked on ibc-go

@alpe alpe changed the base branch from main to app_v2 May 3, 2023 07:59
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, let's add the module to app_v2_config.go and remove setup and legacy registration from app_v2.go

x/wasm/module.go Outdated
depinject.Out

Module appmodule.AppModule
WasmKeeper *Keeper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice, if we can setup and return the scopedWasmKeeper as well.

x/wasm/module.go Outdated
WasmKeeper *Keeper
}

func provideModule(in wasmInputs) wasmOutputs {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function needs to be public or will cause an error on DI

Suggested change
func provideModule(in wasmInputs) wasmOutputs {
func ProvideModule(in wasmInputs) wasmOutputs {

x/wasm/module.go Outdated
depinject.Out

Module appmodule.AppModule
WasmKeeper *Keeper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app_v2.go expects as value of the wasm Keeper. Either change it there or here

import (
fmt "fmt"
io "io"
reflect "reflect"

Check notice

Code scanning / CodeQL

Sensitive package import

Certain system packages contain functions which may be a possible source of non-determinism
@alpe alpe added the blocked label May 5, 2023
@faddat
Copy link
Contributor

faddat commented May 10, 2023

@alpe & @pinosu sirs, keep the fire. This is great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants