Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conda activate fix and development environment #665

Draft
wants to merge 19 commits into
base: develop
Choose a base branch
from
Draft

Conda activate fix and development environment #665

wants to merge 19 commits into from

Conversation

sfarrens
Copy link
Member

@sfarrens sfarrens commented Nov 8, 2023

Summary

closes #651

Reviewer Checklist

Reviewers should tick the following boxes before approving and merging the PR.

  • The PR targets the develop branch
  • The PR is assigned to the developer
  • The PR has appropriate labels
  • The PR is included in appropriate projects and/or milestones
  • The PR includes a clear description of the proposed changes
  • If the PR addresses an open issue the description includes "closes #"
  • The code and documentation style match the current standards
  • Documentation has been added/updated consistently with the code
  • All CI tests are passing
  • API docs have been built and checked at least once (if relevant)
  • All changed files have been checked and comments provided to the developer
  • All of the reviewer's comments have been satisfactorily addressed by the developer

@sfarrens sfarrens added bug Something isn't working enhancement New feature or request labels Nov 8, 2023
@sfarrens sfarrens added this to the ShapePipe v1.1.0 Release milestone Nov 8, 2023
@sfarrens sfarrens self-assigned this Nov 8, 2023
@sfarrens sfarrens marked this pull request as draft November 9, 2023 08:39
martinkilbinger
martinkilbinger reviewed Apr 10, 2024
View reviewed changes
install_shapepipe
# Check Conda minor version
if [ "$CONDA_VERSION_MINOR" -gt 4 ]
# Look for conda.sh file
if [ -f "$CONDA_PREFIX_1$CONDA_SH" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$CONDA_PREFIX_1 does not seem to exist elsewhere in this script.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinkilbinger martinkilbinger martinkilbinger left review comments

Assignees

@sfarrens sfarrens

Labels
bug Something isn't working enhancement New feature or request
Projects
ShapePipe Dev
Status: To do
Milestone
ShapePipe v1.1.0 Release
Development

Successfully merging this pull request may close these issues.

[BUG] Bugs in Conda activation command set up
2 participants
@sfarrens @martinkilbinger