Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: x/clock v2 - permissionless #893

Merged
merged 39 commits into from
Dec 14, 2023
Merged

feat!: x/clock v2 - permissionless #893

merged 39 commits into from
Dec 14, 2023

Conversation

joelsmith-2019
Copy link
Contributor

@joelsmith-2019 joelsmith-2019 commented Nov 22, 2023 •
edited
Loading

Closes #861

REMAINING TASKS

Keeper:

  • clock.go: Ensure senderAddress is admin (first) then creator (second)

Querier:

  • Get all contracts (jailed & unjailed)
  • Get contract by address

Genesis:

  • List of all registered contracts
  • List all jailed contracts
  • Display gas

Codec:

  • Update Codec: Update with new Tx Messages

EndBlocker:

  • Execute up to 100k gas
  • If contract errors, jail contract

Testing:

  • Unit Tests on Msg Server
  • Unit Tests on Querier
  • Unit Tests on Params (params_test.go)
  • Unit Tests on Genesis (genesis_test.go)
  • Unit Tests on Codec
  • Unit Tests on Msg
  • End Blocker Tests?
  • Interchain Tests
  • Interchain Test Unregistering a contract!

Documentation

  • Update Documentation with new CLI, Logic, Etc.

@joelsmith-2019 joelsmith-2019 self-assigned this Nov 22, 2023
@joelsmith-2019 joelsmith-2019 linked an issue Nov 22, 2023 that may be closed by this pull request
x/clock - permissionless #861
Closed
@joelsmith-2019 joelsmith-2019 changed the title update: x/clock v2 - permissionless feat!: x/clock v2 - permissionless Nov 24, 2023
Reecepbcups
Reecepbcups reviewed Nov 28, 2023
View reviewed changes
x/clock/abci.go Outdated Show resolved Hide resolved
proto/juno/clock/v1/genesis.proto Outdated Show resolved Hide resolved
x/clock/client/cli/tx.go Outdated Show resolved Hide resolved
x/clock/genesis.go Outdated Show resolved Hide resolved
x/clock/genesis.go Outdated Show resolved Hide resolved
x/clock/keeper/msg_server.go Outdated Show resolved Hide resolved
x/clock/keeper/querier.go Outdated Show resolved Hide resolved
x/clock/keeper/querier.go Outdated Show resolved Hide resolved
x/clock/types/codec.go Outdated Show resolved Hide resolved
x/clock/keeper/clock.go Outdated Show resolved Hide resolved
@joelsmith-2019 joelsmith-2019 added the review me Review me for merge label Dec 8, 2023
@joelsmith-2019 joelsmith-2019 marked this pull request as ready for review December 12, 2023 01:33
Reecepbcups
Reecepbcups reviewed Dec 12, 2023
View reviewed changes
x/clock/types/params_test.go Show resolved Hide resolved
x/clock/types/msgs.go Outdated Show resolved Hide resolved
interchaintest/module_clock_test.go Show resolved Hide resolved
Reecepbcups
Reecepbcups reviewed Dec 13, 2023
View reviewed changes
x/clock/abci.go Outdated Show resolved Hide resolved
@Reecepbcups Reecepbcups merged commit 3dadeb5 into main Dec 14, 2023
25 checks passed
@Reecepbcups
Copy link
Contributor

Great work!

@joelsmith-2019 joelsmith-2019 deleted the joel/permissionless-clock branch February 2, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pipello Pipello Pipello left review comments

@Reecepbcups Reecepbcups Reecepbcups approved these changes

@the-frey the-frey Awaiting requested review from the-frey

@JakeHartnell JakeHartnell Awaiting requested review from JakeHartnell JakeHartnell is a code owner

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@dimiandre dimiandre Awaiting requested review from dimiandre dimiandre is a code owner

Assignees

@joelsmith-2019 joelsmith-2019

Labels
review me Review me for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x/clock - permissionless
3 participants
@joelsmith-2019 @Reecepbcups @Pipello