Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CGS small update #2984

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

CGS small update #2984

wants to merge 15 commits into from

Conversation

Samma2009
Copy link

  • fixed DrawFilledEllipse function
  • added GetPixels function (gets a rectangle of pixels from the canvas and stores them into a bitmap)
  • added image resize functions

sorry for all the ghost additions and delitions but my github went crazy

- fixed DrawFilledEllipse function
- added GetPixels function (gets a rectangle of pixels from the canvas and stores them into a bitmap)
- added image resize functions
Copy link
Contributor

@PratyushKing PratyushKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems about right

Copy link
Member

@quajak quajak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!

Please see my attached requested changes. Can you please also remove the changes to the packages.lock from the jsons?

source/Cosmos.System2/Graphics/Canvas.cs Outdated Show resolved Hide resolved
source/Cosmos.System2/Graphics/Bitmap.cs Outdated Show resolved Hide resolved
source/Cosmos.System2/Graphics/Bitmap.cs Show resolved Hide resolved
/// <param name="NewW">the new width of the bitmap</param>
/// <param name="NewH">the new height of the bitmap</param>
/// <returns>resized image</returns>
public static Bitmap Resize(Bitmap image, uint NewW, uint NewH)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename NewW to newWidth and NewH to newHeight

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not fixed

source/Cosmos.System2/Graphics/Image.cs Outdated Show resolved Hide resolved
source/Cosmos.System2/Graphics/Image.cs Show resolved Hide resolved
source/Cosmos.System2/Graphics/Bitmap.cs Show resolved Hide resolved
source/Cosmos.System2/Graphics/Bitmap.cs Outdated Show resolved Hide resolved
source/Cosmos.System2/Graphics/Canvas.cs Outdated Show resolved Hide resolved
@Samma2009
Copy link
Author

@quajak all the commit requests have been accepted, also about the the getpixels function, i have moved it to the bitmap class.

@Samma2009 Samma2009 marked this pull request as draft March 9, 2024 17:14
@Samma2009 Samma2009 marked this pull request as ready for review March 9, 2024 17:16
Copy link
Member

@quajak quajak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the other requested changes before we can merge this.

source/Cosmos.System2/Graphics/Bitmap.cs Outdated Show resolved Hide resolved
source/Cosmos.System2/Graphics/Bitmap.cs Outdated Show resolved Hide resolved
@Samma2009
Copy link
Author

@quajak Done, i have fixed any remaning changes. about the packages.lock thing.... i don't know how to revert it. could you tell me

Copy link
Member

@quajak quajak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the requested changes. Regarding the lock files, the easiest way might be to manually revert the changes in the files

/// <returns>Bitmap</returns>
public static Bitmap FromCanvasRegion(Canvas canvas, int X, int Y, ushort W, ushort H)
{

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the additional new lines and tabbing of the function

source/Cosmos.System2/Graphics/Image.cs Show resolved Hide resolved
@9xbt
Copy link
Contributor

9xbt commented Apr 5, 2024

Bruh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants