feature/any-audio-file-type #15
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # speakerbox/preprocess.py
evamaxfield
reviewed
Dec 12, 2022
|
Seems like tests are breaking but they dont seem to be related to your changes... Will look in a bit. |
|
Really sorry on the delay on this. If you are still interested, can you merge main and push -- I think everything should be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Relevant Issue
This pull request resolves #14
Description of Changes
Change only on 1 line, glob("*.wav") => chain of globs for every relevant audio file format.
NB : I have not run the
justcommand and made no tests, no enough time to do so. But my code works, very simple change made.