[SDK-713] Bug fix for 21.11.3 (manual rating) (#184)

* bug fix + log * some typos and wording * s * changelog * vers min * Update CHANGELOG.md Co-authored-by: ArtursKadikis <[email protected]>
Countly · Mar 15, 2022 · 98b0341 · 98b0341
1 parent d9f43b9
commit 98b0341
Show file tree

Hide file tree

Showing 5 changed files with 64 additions and 60 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
+## 21.11.3
+- Fixed a bug with `recordRatingWidgetWithID` where it would not record ratings
+
 ## 21.11.2
 - Fixed a bug where request queue was not processing
+
 ## 21.11.1
 - Fixed feedback widget bug related to the 'close events' origin check
 - When consent is changed it will now send the full consent state instead of just the changed consents

diff --git a/README.md b/README.md
@@ -30,7 +30,7 @@ or
 
 Countly web SDK is available on CDNJS. Use either
 
-[https://cdnjs.cloudflare.com/ajax/libs/countly-sdk-web/21.11.2/countly.min.js](https://cdnjs.cloudflare.com/ajax/libs/countly-sdk-web/21.11.2/countly.min.js)
+[https://cdnjs.cloudflare.com/ajax/libs/countly-sdk-web/21.11.3/countly.min.js](https://cdnjs.cloudflare.com/ajax/libs/countly-sdk-web/21.11.3/countly.min.js)
 
 or
 

diff --git a/lib/countly.js b/lib/countly.js
@@ -92,14 +92,14 @@
      * Countly.utm = {"source": true, "medium": true, "campaign": true, "term": true, "content": true};
      */
     Countly.utm = { source: true, medium: true, campaign: true, term: true, content: true };
-    // For testing purposes only-- indicates that countly is not initiated
+    // For testing purposes only-- indicates that Countly is not initiated
 
     /**
      * At the current moment there are following internal events and their respective required consent:
         [CLY]_nps - "feedback" consent
         [CLY]_survey - "feedback" consent
         [CLY]_star_rating - "star_rating" consent
-        [CLY]_view - "view" consent
+        [CLY]_view - "views" consent
         [CLY]_orientation - "users" consent
         [CLY]_push_action - "push" consent
         [CLY]_action - "clicks" or "scroll" consent
@@ -149,7 +149,7 @@
     */
     Countly.onload = Countly.onload || [];
 
-    var SDK_VERSION = "21.11.2";
+    var SDK_VERSION = "21.11.3";
     var SDK_NAME = "javascript_native_web";
 
     var urlParseRE = /^(((([^:\/#\?]+:)?(?:(\/\/)((?:(([^:@\/#\?]+)(?:\:([^:@\/#\?]+))?)@)?(([^:\/#\?\]\[]+|\[[^\/\]@#?]+\])(?:\:([0-9]+))?))?)?)?((\/?(?:[^\/\?#]+\/+)*)([^\?#]*)))?(\?[^#]+)?)(#.*)?/;
@@ -1041,7 +1041,7 @@
         * @name Countly.userData
         * @example
         * //set custom key value property
-        * Countly.userData.set("twitter", "ar2rsawseen");
+        * Countly.userData.set("twitter", "hulk@rowboat");
         * //create or increase specific number property
         * Countly.userData.increment("login_count");
         * //add new value to array property if it is not already there
@@ -2129,8 +2129,8 @@
             if (!event.segmentation.app_version) {
                 event.segmentation.app_version = this.metrics._app_version || this.app_version;
             }
-            log(logLevelEnums.ERROR, "recordRatingWidgetWithID, Reporting Rating Widget: ", event);
-            this.add_cly_event(event);
+            log(logLevelEnums.INFO, "recordRatingWidgetWithID, Reporting Rating Widget: ", event);
+            add_cly_events(event);
         };
         /**
         * Show specific widget popup by the widget id
@@ -2421,9 +2421,9 @@
                     }
 
                     // Setting initiated marks the first time initiation of the iframe.
-                    // When initiated for the first time, do not hide the survey bcz you want
+                    // When initiated for the first time, do not hide the survey because you want
                     // the survey to be shown for the first time.
-                    // Any subsequent onloads mean that the survey is being refreshed or reset.
+                    // Any subsequent onload means that the survey is being refreshed or reset.
                     // This time hide it as being done in the above check.
                     initiated = true;
                 };
@@ -3530,7 +3530,7 @@
         };
 
         /**
-        * Expose internal methods for pluggable code to reuse them
+        * Expose internal methods to end user for usability
         * @namespace Countly._internals
         * @name Countly._internals
         */
@@ -3866,7 +3866,7 @@
 
     /**
      *  Polyfill to get closest parent matching nodeName
-     *  @param {HTMLElementng} el - element from which to search
+     *  @param {HTMLElement} el - element from which to search
      *  @param {String} nodeName - tag/node name
      *  @returns {HTMLElement} closest parent element
      */
@@ -4119,7 +4119,7 @@
      *  @memberof Countly._internals
      */
     function hideLoader() {
-        // Inform showloader's onload that it should not append loader
+        // Inform showLoader that it should not append the loader
         Countly.showLoaderProtection = true;
         var loader = document.getElementById("cly-loader");
         if (loader) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -30,7 +30,7 @@ or @@
     Countly web SDK is available on CDNJS. Use either
-    [https://cdnjs.cloudflare.com/ajax/libs/countly-sdk-web/21.11.2/countly.min.js](https://cdnjs.cloudflare.com/ajax/libs/countly-sdk-web/21.11.2/countly.min.js)
+    [https://cdnjs.cloudflare.com/ajax/libs/countly-sdk-web/21.11.3/countly.min.js](https://cdnjs.cloudflare.com/ajax/libs/countly-sdk-web/21.11.3/countly.min.js)
     or
@@ Expand Down @@