Multiple Reference Timelines: Timeline Designer, Manage Users extensions #5631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purfectliterature
added
Feature
UI
Depends on
purfectliterature
force-pushed
the
phillmont/timelines-designer
branch
from
0157a83
to
91782b9
Compare
purfectliterature
force-pushed
the
phillmont/multiple-reference-timelines
branch
2 times, most recently
from
18c5a41
to
8b99b60
Compare
ekowidianto
force-pushed
the
phillmont/timelines-designer
branch
2 times, most recently
from
faa9daa
to
911e0c3
Compare
purfectliterature
force-pushed
the
phillmont/multiple-reference-timelines
branch
2 times, most recently
from
2c31997
to
cd776af
Compare
purfectliterature
force-pushed
the
phillmont/multiple-reference-timelines
branch
2 times, most recently
from
01e4a8a
to
a56af93
Compare
ekowidianto
approved these changes
Jan 16, 2023
There was a problem hiding this comment.
@purfectliterature I am impressed! Awesome work within 3 weeks! Really great work - a very complicated task with good code!
Some nits and clarifying questions below.
client/app/bundles/course/reference-timelines/store/timelinesSlice.ts
Outdated
Show resolved
Hide resolved
client/app/bundles/course/reference-timelines/components/TimelinesStack/TimelinesStack.tsx
Show resolved
Hide resolved
client/app/bundles/course/reference-timelines/components/TimelinesStack/TimelinesStack.tsx
Show resolved
Hide resolved
client/app/bundles/course/reference-timelines/components/TimePopup/TimePopup.tsx
Show resolved
Hide resolved
client/app/bundles/course/reference-timelines/components/SeriouslyAnchoredPopup.tsx
Show resolved
Hide resolved
client/app/bundles/course/reference-timelines/components/TimeBar/TimeBar.tsx
Show resolved
Hide resolved
purfectliterature
force-pushed
the
phillmont/multiple-reference-timelines
branch
from
a56af93
to
1dec964
Compare
purfectliterature
force-pushed
the
phillmont/timelines-designer
branch
from
911e0c3
to
e3e67e2
Compare
purfectliterature
force-pushed
the
phillmont/multiple-reference-timelines
branch
4 times, most recently
from
b9b393f
to
a45cd39
Compare
purfectliterature
force-pushed
the
phillmont/timelines-designer
branch
2 times, most recently
from
209ed70
to
ddec2c8
Compare
purfectliterature
changed the title
ekowidianto
reviewed
Jan 18, 2023
client/app/bundles/course/reference-timelines/components/SearchField.tsx
Outdated
Show resolved
Hide resolved
ekowidianto
reviewed
Jan 18, 2023
client/app/bundles/course/announcements/components/misc/AnnouncementsDisplay.tsx
Outdated
Show resolved
Hide resolved
redux toolkit already re-exports the same `createSelector` from reselect
purfectliterature
force-pushed
the
phillmont/timelines-designer
branch
from
d2ac46a
to
c3ec6f7
Compare
purfectliterature
force-pushed
the
phillmont/timelines-designer
branch
from
c3ec6f7
to
ca92a21
Compare
ekowidianto
reviewed
Jan 18, 2023
client/app/bundles/course/users/components/tables/ManageUsersTable.tsx
Outdated
Show resolved
Hide resolved
purfectliterature
force-pushed
the
phillmont/timelines-designer
branch
from
ca92a21
to
9850d5b
Compare
ekowidianto
approved these changes
Jan 18, 2023
purfectliterature
force-pushed
the
phillmont/timelines-designer
branch
from
9850d5b
to
f30d740
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #5491. Closes #4202.