Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply CE UI changes to Winsparkle #3

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

jaredburkeen
Copy link

@jaredburkeen jaredburkeen commented Mar 9, 2018

What's New?

  • Modify UI per UX.
  • Modified minimum check interval for testing purposes (lowered from 1 hour to 5 minutes).
  • Also changed it so the update interval value can be changed on-the-fly and still take affect.

@jaredburkeen jaredburkeen requested a review from loberlander March 9, 2018 15:12
@jaredburkeen
Copy link
Author

@loberlander This is ready for your review.

@jaredburkeen
Copy link
Author

@loberlander This is ready for review as well.

@loberlander
Copy link

loberlander commented Mar 21, 2018

Some general comments:

  • The Windows Registry keys remain after an uninstall: Computer\HKEY_CURRENT_USER\Software\Covenant Eyes, Inc.\Covenant Eyes\WinSparkle, consider moving WinSparkle under the already existing key (Covenant Eyes)
  • Winsparkle runs immediately after install/initial start, prompting for update (when available) as the LastCheckTime is not set yet, it would be nice to delay the initial check by some time, maybe set the registry key from the installer to current time
  • The options in the drop down list are not consistent
    in 1 hour vs in an hour
    tomorrow vs in a day
    in 1 week vs in a week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants