Merge pull request #4 from CrowdStrike/lint-fixes

Lint fixes
CrowdStrike · Sep 25, 2024 · 273a488 · 273a488
2 parents e91544a + 07a2572
commit 273a488
Show file tree

Hide file tree

Showing 11 changed files with 142 additions and 47 deletions.
diff --git a/.eslintrc.yml b/.eslintrc.yml
@@ -19,6 +19,8 @@ plugins:
 rules:
   prettier/prettier:
     - error
+  react/prop-types:
+    - warn
 settings:
   react:
     version: detect
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -3,8 +3,16 @@ name: Node.js CI
 on:
   push:
     branches: [ "main" ]
+    paths-ignore:
+      - 'README.md'
+      - '.devcontainer/**'
+      - '.github/**'
   pull_request:
     branches: [ "main" ]
+    paths-ignore:
+      - 'README.md'
+      - '.devcontainer/**'
+      - '.github/**'
 
 jobs:
   ci:

diff --git a/.github/workflows/container_build.yml b/.github/workflows/container_build.yml
@@ -1,9 +1,17 @@
 name: Container Build
 on:
   push:
-    branches: [ main ]
+    branches: [ "main" ]
+    paths-ignore:
+      - 'README.md'
+      - '.devcontainer/**'
+      - '.github/**'
   pull_request:
-    branches: [ main ]
+    branches: [ "main" ]
+    paths-ignore:
+      - 'README.md'
+      - '.devcontainer/**'
+      - '.github/**'
 
 jobs:
   build:

diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml
@@ -3,8 +3,16 @@ name: Yarn Lint
 on:
   push:
     branches: [ "main" ]
+    paths-ignore:
+      - 'README.md'
+      - '.devcontainer/**'
+      - '.github/**'
   pull_request:
     branches: [ "main" ]
+    paths-ignore:
+      - 'README.md'
+      - '.devcontainer/**'
+      - '.github/**'
 
 jobs:
   lint:

diff --git a/.stylelintrc.yaml b/.stylelintrc.yaml
@@ -15,8 +15,10 @@ rules:
   # Disallow CSS classnames prefixed with .pf- or .co- as these prefixes are
   # reserved by PatternFly and OpenShift console.
   selector-disallowed-list:
-    - "*"
-    - /\.(pf|co)-/
+    # Due to a issue with PF: https://github.com/openshift/console/pull/14246
+    - null
+    # - "*"
+    # - /\.(pf|co)-/
   # Plugins should avoid naked element selectors like `table` and `li` since
   # this can impact layout of existing pages in console.
   selector-max-type:

diff --git a/src/components/missing-pf-styles.css b/src/components/missing-pf-styles.css
diff --git a/src/components/pod/PodTab.tsx b/src/components/pod/PodTab.tsx
@@ -15,9 +15,9 @@ export default function PodDetails({ obj }) {
     },
   ];
 
-  const detectionsBody = detections.map((d) => {
+  const detectionsBody = detections.map((d, index) => {
     return (
-      <Tr>
+      <Tr key={index}>
         <Td>{d.severity}</Td>
         <Td>{d.description}</Td>
         <Td>{d.action}</Td>

diff --git a/src/components/virt/DetectionsTable.tsx b/src/components/virt/DetectionsTable.tsx
@@ -85,7 +85,7 @@ export default function DetectionsTable({ client, deviceId, alerts, setAlerts })
           <DataList aria-label="Endpoint alerts">
             {alerts.map((a) => {
               return (
-                <DataListItem isExpanded={expanded.includes(a.compositeId)}>
+                <DataListItem key={a.compositeId} isExpanded={expanded.includes(a.compositeId)}>
                   <DataListItemRow>
                     <DataListToggle
                       onClick={() => toggle(a.compositeId)}
@@ -94,12 +94,18 @@ export default function DetectionsTable({ client, deviceId, alerts, setAlerts })
                     />
                     <DataListItemCells
                       dataListCells={[
-                        <DataListCell width={4}>{a.description}</DataListCell>,
-                        <DataListCell width={1}>{a.tactic}</DataListCell>,
-                        <DataListCell width={1}>
+                        <DataListCell key="description" width={4}>
+                          {a.description}
+                        </DataListCell>,
+                        <DataListCell key="tactic" width={1}>
+                          {a.tactic}
+                        </DataListCell>,
+                        <DataListCell key="severity" width={1}>
                           <SeverityLabel name={a.severityName} />
                         </DataListCell>,
-                        <DataListCell width={2}>{a.timestamp.toUTCString()}</DataListCell>,
+                        <DataListCell key="timestamp" width={2}>
+                          {a.timestamp.toUTCString()}
+                        </DataListCell>,
                       ]}
                     />
                     <DataListAction

diff --git a/src/components/virt/NoAgent.tsx b/src/components/virt/NoAgent.tsx
@@ -21,8 +21,8 @@ export default function NoAgent() {
       />
       <EmptyStateBody>
         <p>
-          We couldn't find a running Falcon agent that matches this system's MAC address. If the
-          agent is installed, make sure the <code>falcon-sensor</code> service is running.
+          We couldn&apos;t find a running Falcon agent that matches this system&apos;s MAC address.
+          If the agent is installed, make sure the <code>falcon-sensor</code> service is running.
         </p>
       </EmptyStateBody>
       <EmptyStateFooter>

diff --git a/src/components/virt/VulnsTable.tsx b/src/components/virt/VulnsTable.tsx
@@ -120,7 +120,7 @@ export default function VulnsTable({ client, deviceId, vulns, setVulns }) {
             <DataList aria-label="Remediations">
               {sortedRemediations.map((r) => {
                 return (
-                  <DataListItem isExpanded={expanded.includes(r.id)}>
+                  <DataListItem key={r.id} isExpanded={expanded.includes(r.id)}>
                     <DataListItemRow>
                       <DataListToggle
                         onClick={() => toggle(r.id)}
@@ -129,9 +129,13 @@ export default function VulnsTable({ client, deviceId, vulns, setVulns }) {
                       />
                       <DataListItemCells
                         dataListCells={[
-                          <DataListCell width={4}>{r.action}</DataListCell>,
-                          <DataListCell width={2}>{r.maxBaseScore}</DataListCell>,
-                          <DataListCell width={2}>
+                          <DataListCell key="action" width={4}>
+                            {r.action}
+                          </DataListCell>,
+                          <DataListCell key="maxscore" width={2}>
+                            {r.maxBaseScore}
+                          </DataListCell>,
+                          <DataListCell key="severity" width={2}>
                             <SeverityLabel
                               name="critical"
                               text={r.counts.critical}
@@ -172,7 +176,7 @@ export default function VulnsTable({ client, deviceId, vulns, setVulns }) {
                         <Tbody>
                           {r.cves.map((c) => {
                             return (
-                              <Tr>
+                              <Tr key={c.id}>
                                 <Td>{c.id}</Td>
                                 <Td>{c.baseScore}</Td>
                                 <Td>

diff --git a/src/components/virt/style.css b/src/components/virt/style.css
@@ -8,15 +8,15 @@ ul.crwd-process-tree-child {
 }
 
 ul.crwd-process-tree-child li::marker {
-  color: #8A8D90;
+  color: var(--pf-global--Color--400);
 }
 
 ul.crwd-process-tree-root pre, ul.crwd-process-tree-child pre {
   text-wrap: wrap;
 }
 
 ul.crwd-process-tree-root li, ul.crwd-process-tree-child li {
-  padding: 5px 0px 0px 5px;
+  padding: 5px 0 0 5px;
 }
 
 div.crwd-card-title {