Mainline dark icon invert attribute

Additionally, don't completely invert dark icons for the Moonshot theme.
Croydon · Mar 13, 2024 · 1ab9c2b · 1ab9c2b
1 parent ea308b6
commit 1ab9c2b
Show file tree

Hide file tree

Showing 9 changed files with 19 additions and 11 deletions.
diff --git a/data/template/basic/index.css b/data/template/basic/index.css
@@ -165,6 +165,9 @@
 	--vtr-tab-pinned-hover-padding-bottom: var(--vtr-tab-hover-padding-bottom);
 	--vtr-tab-pinned-hover-padding-left: var(--vtr-tab-hover-padding-left);
 
+	/* Favicon */
+	--vtr-tab-icon-invert-dark-icons: 0;
+
 	/* Close buttons */
 	--vtr-tab-button-close-width: 20px;
 	--vtr-tab-button-close-height: 20px;

diff --git a/data/template/basic/tab.css b/data/template/basic/tab.css
@@ -175,6 +175,10 @@
 	opacity: 1;
 }
 
+.tab-icon-image-dark {
+	filter: invert(var(--vtr-tab-icon-invert-dark-icons));
+}
+
 .tabbrowser-tab:not(:hover):not([selected="true"]) .tab-close-button {
 	display: none;
 }

diff --git a/data/theme/dark/index.css b/data/theme/dark/index.css
@@ -112,6 +112,9 @@
 	--vtr-tab-hover-border-top: 2px solid #FFFFFF;
 	--vtr-tab-hover-border-bottom: 2px solid #FFFFFF;
 
+	/* Favicon */
+	--vtr-tab-icon-invert-dark-icons: 1;
+
 	/* Close button */
 	--vtr-tab-button-close-width: 18px;
 	--vtr-tab-button-close-height: 18px;

diff --git a/data/theme/dark/modifications.css b/data/theme/dark/modifications.css
@@ -1,3 +1 @@
-.tab-icon-image-dark {
-    filter: invert(1);
-}
+/* No modifications so far */
diff --git a/data/theme/darwin/index.css b/data/theme/darwin/index.css
@@ -113,6 +113,9 @@
 	--vtr-tab-hover-border-top: 2px solid #FFFFFF;
 	--vtr-tab-hover-border-bottom: 2px solid #FFFFFF;
 
+	/* Favicon */
+	--vtr-tab-icon-invert-dark-icons: 1;
+
 	/* Close buttons */
 	--vtr-tab-button-close-width: 14px;
 	--vtr-tab-button-close-height: 14px;

diff --git a/data/theme/darwin/modifications.css b/data/theme/darwin/modifications.css
@@ -17,10 +17,6 @@
     /*opacity: 0.7;   turn black into #b9b9b9
 }*/
 
-.tab-icon-image-dark {
-    filter: invert(1);
-}
-
 .tab-close-button:active {
      opacity: 0.75;   /* turn black into #8a8a8a */
 }

diff --git a/data/theme/moonshot/index.css b/data/theme/moonshot/index.css
@@ -122,6 +122,9 @@
 	--vtr-tab-hover-border-top: 2px solid #FFFFFF;
 	--vtr-tab-hover-border-bottom: 2px solid #FFFFFF;
 
+	/* Favicon */
+	--vtr-tab-icon-invert-dark-icons: 0.8;
+
 	/* Close button */
 	--vtr-tab-button-close-width: 18px;
 	--vtr-tab-button-close-height: 18px;

diff --git a/data/theme/moonshot/modifications.css b/data/theme/moonshot/modifications.css
@@ -1,3 +1 @@
-.tab-icon-image-dark {
-    filter: invert(1);
-}
+/* No modifications so far */
diff --git a/manifest.json b/manifest.json
@@ -2,7 +2,7 @@
     "name": "Vertical Tabs Reloaded",
     "short_name": "VTR",
     "description": "This Firefox add-on arranges tabs in a vertical rather than horizontal fashion.",
-    "version": "0.14.0.10",
+    "version": "0.14.0.11",
     "version_name": "0.14.0",
     "manifest_version": 2,
     "author": "Michael 'Croydon' Keck",