GT-2214 Undownload language button

[rachaelblue]

Current logic is that tapping once on a downloaded language should show the red "x", and tapping a second time removes the download. Waiting to hear back from Jill if there's supposed to be a way to cancel if a user gets the "x" but doesn't want to download. Depending on what the solution is, I'm thinking that will just be a separate ticket.

[levieggertcru]

Hey @rachaelblue sounds good, it seems there definitely needs to be something to reverse that.

I also have a change request which could be done in that separate ticket or this one. Let me know which you'd prefer, but I was looking at DownloadableLanguagesViewModel.swift and instead of having a single input downloadableLanguageTapped I would like 2 separate inputs. An input for downloading a language and an input for removing a language.

The ViewModel doesn't necessarily know how the View is structuring UI elements or that it's sharing the tap action for those, it simply declares what inputs are available to the View and it's up to the View to call those.

[rachaelblue]

Hey @levieggertcru, since Jill's change to hide the "x" was simple enough (cancel after 3 seconds unless tapped again), I went ahead and did that here as well as splitting the input into two separate ones.

[codecov]

Codecov Report

Attention: 84 lines in your changes are missing coverage. Please review.

Comparison is base (6f3e76b) 20.91% compared to head (3cd8829) 20.72%.
Report is 22 commits behind head on develop.

Files	Patch %	Lines
...guages/Subviews/DownloadableLanguageItemView.swift	0.00%	45 Missing ⚠️
...ableLanguages/DownloadableLanguagesViewModel.swift	0.00%	20 Missing ⚠️
...dableLanguages/Subviews/LanguageDownloadIcon.swift	0.00%	10 Missing ⚠️
...nloadableLanguages/DownloadableLanguagesView.swift	0.00%	9 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1943      +/-   ##
===========================================
- Coverage    20.91%   20.72%   -0.19%     
===========================================
  Files         1008     1008              
  Lines        31576    31628      +52     
===========================================
- Hits          6604     6556      -48     
- Misses       24972    25072     +100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[levieggertcru]

Thanks @rachaelblue looks good.