GT-2478 add error handling and view model for downloadable language #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-item-view' into GT-2478-add-error-handling
…d with a SwiftUI view onReceive modifier
… as a single publisher. Now all translation downloads for non articles are counted and all article downloads are counted
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2456 +/- ##
===========================================
+ Coverage 95.89% 95.91% +0.01%
===========================================
Files 62 62
Lines 5315 5315
===========================================
+ Hits 5097 5098 +1
+ Misses 218 217 -1 ☔ View full report in Codecov by Sentry. |
Add errors to ToolDownloaderDataModel
…g reference alive
# Conflicts: # godtools/App/Features/AppLanguage/Data/ToolLanguageDownloader/ToolLanguageDownloader.swift # godtools/App/Share/Data/ToolDownloader/ToolDownloader.swift
# Conflicts: # godtools/App/Features/AppLanguage/Domain/Entities/DownloadableLanguageListItemDomainModel.swift # godtools/App/Features/AppLanguage/Presentation/DownloadableLanguages/DownloadableLanguagesViewModel.swift
Set initial progress target to 0.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.