Skip to content
Qodana

Instancing Rework #221

Sign in to view logs

Instancing Rework

Instancing Rework #221

Triggered via pull request November 16, 2024 13:04
@DesoroxxxDesoroxxx
synchronize #510
instancing-rework
Status Success
Total duration 24m 26s
Artifacts –

code_quality.yml

on: pull_request
qodana
24m 14s
qodana
Fit to window
Zoom out
Zoom in

Annotations

52 warnings and 2 notices
Auto-boxing: src/main/java/com/paneedah/mwc/handlers/DebugHandler.java#L36
Auto-boxing `MWC.modContext.getPlayerItemInstanceRegistry().getCacheSize()`
Auto-boxing: src/main/java/com/paneedah/weaponlib/PlayerWeaponInstance.java#L47
Auto-boxing `hasOpticalScope() ? 10 : 5`
Auto-boxing: src/main/java/com/paneedah/weaponlib/PlayerWeaponInstance.java#L55
Auto-boxing `getOpticalScopeVignetteRadius(context.getPartialTicks())`
Auto-boxing: src/main/java/com/paneedah/weaponlib/PlayerWeaponInstance.java#L52
Auto-boxing `2 + 3 * MC.gameSettings.gammaSetting`
Auto-boxing: src/main/java/com/paneedah/weaponlib/PlayerWeaponInstance.java#L51
Auto-boxing `40 - MC.gameSettings.gammaSetting * 38`
Auto-boxing: src/main/java/com/paneedah/weaponlib/PlayerItemInstanceRegistry.java#L281
Auto-boxing `entry.getIntKey()`
Constant values: src/main/java/com/paneedah/weaponlib/ClientEventHandler.java#L247
Condition `mainHandHeldWeaponInstance != null` is always `true`
Nullability and data flow problems: src/main/java/com/paneedah/weaponlib/compatibility/CompatibleExposureCapability.java#L104
Method invocation `getClass` may produce `NullPointerException`
@NotNull/@Nullable problems: src/main/java/com/paneedah/mwc/commands/client/ClientCommandBase.java#L25
Not annotated parameter overrides @ParametersAreNonnullByDefault parameter
@NotNull/@Nullable problems: src/main/java/com/paneedah/mwc/commands/client/CommandPlayerItemInstanceRegistry.java#L60
Not annotated method overrides method annotated with @MethodsReturnNonnullByDefault
@NotNull/@Nullable problems: src/main/java/com/paneedah/mwc/commands/client/CommandPlayerItemInstanceRegistry.java#L65
Not annotated parameter overrides @ParametersAreNonnullByDefault parameter
@NotNull/@Nullable problems: src/main/java/com/paneedah/mwc/commands/client/ClientCommandBase.java#L25
Not annotated parameter overrides @ParametersAreNonnullByDefault parameter
@NotNull/@Nullable problems: src/main/java/com/paneedah/mwc/commands/MWCCommand.java#L32
Not annotated method overrides method annotated with @MethodsReturnNonnullByDefault
@NotNull/@Nullable problems: src/main/java/com/paneedah/mwc/commands/client/CommandPlayerItemInstanceRegistry.java#L32
Not annotated method overrides method annotated with @MethodsReturnNonnullByDefault
@NotNull/@Nullable problems: src/main/java/com/paneedah/mwc/commands/client/CommandPlayerItemInstanceRegistry.java#L45
Not annotated method overrides method annotated with @MethodsReturnNonnullByDefault
@NotNull/@Nullable problems: src/main/java/com/paneedah/mwc/commands/client/CommandPlayerItemInstanceRegistry.java#L32
Not annotated parameter overrides @ParametersAreNonnullByDefault parameter
@NotNull/@Nullable problems: src/main/java/com/paneedah/mwc/commands/client/CommandPlayerItemInstanceRegistry.java#L70
Not annotated parameter overrides @ParametersAreNonnullByDefault parameter
@NotNull/@Nullable problems: src/main/java/com/paneedah/mwc/commands/client/CommandPlayerItemInstanceRegistry.java#L70
Not annotated parameter overrides @ParametersAreNonnullByDefault parameter
@NotNull/@Nullable problems: src/main/java/com/paneedah/mwc/commands/client/CommandPlayerItemInstanceRegistry.java#L45
Not annotated parameter overrides @ParametersAreNonnullByDefault parameter
@NotNull/@Nullable problems: src/main/java/com/paneedah/mwc/commands/client/CommandPlayerItemInstanceRegistry.java#L50
Not annotated parameter overrides @ParametersAreNonnullByDefault parameter
@NotNull/@Nullable problems: src/main/java/com/paneedah/mwc/commands/client/CommandPlayerItemInstanceRegistry.java#L40
Not annotated method overrides method annotated with @MethodsReturnNonnullByDefault
@NotNull/@Nullable problems: src/main/java/com/paneedah/mwc/commands/MWCCommand.java#L37
Not annotated method overrides method annotated with @MethodsReturnNonnullByDefault
@NotNull/@Nullable problems: src/main/java/com/paneedah/mwc/commands/client/CommandPlayerItemInstanceRegistry.java#L50
Not annotated parameter overrides @ParametersAreNonnullByDefault parameter
@NotNull/@Nullable problems: src/main/java/com/paneedah/mwc/commands/client/CommandPlayerItemInstanceRegistry.java#L65
Not annotated method overrides method annotated with @MethodsReturnNonnullByDefault
@NotNull/@Nullable problems: src/main/java/com/paneedah/mwc/commands/MWCCommand.java#L37
Not annotated parameter overrides @ParametersAreNonnullByDefault parameter
@NotNull/@Nullable problems: src/main/java/com/paneedah/mwc/commands/client/ClientCommandTreeBase.java#L23
Not annotated parameter overrides @ParametersAreNonnullByDefault parameter
@NotNull/@Nullable problems: src/main/java/com/paneedah/mwc/commands/MWCCommand.java#L27
Not annotated method overrides method annotated with @MethodsReturnNonnullByDefault
@NotNull/@Nullable problems: src/main/java/com/paneedah/mwc/commands/client/ClientCommandTreeBase.java#L23
Not annotated parameter overrides @ParametersAreNonnullByDefault parameter
@NotNull/@Nullable problems: src/main/java/com/paneedah/mwc/commands/client/CommandPlayerItemInstanceRegistry.java#L27
Not annotated method overrides method annotated with @MethodsReturnNonnullByDefault
Unchecked warning: src/main/java/com/paneedah/weaponlib/PlayerItemInstanceRegistry.java#L240
Unchecked cast: 'com.paneedah.weaponlib.PlayerItemInstance\>' to 'T'
Unchecked warning: src/main/java/com/paneedah/mwc/network/TypeRegistry.java#L95
Unchecked cast: 'java.lang.Class\>' to 'java.lang.Class'
Unused import: src/main/java/com/paneedah/weaponlib/melee/MeleeState.java#L3
Unused import `import com.paneedah.mwc.network.TypeRegistry;`
Unused import: src/main/java/com/paneedah/weaponlib/CommonModContext.java#L8
Unused import `import com.paneedah.weaponlib.WeaponAttachmentAspect.ChangeAttachmentPermit;`
Unused import: src/main/java/com/paneedah/weaponlib/electronics/TabletState.java#L3
Unused import `import com.paneedah.mwc.network.TypeRegistry;`
Unused import: src/main/java/com/paneedah/weaponlib/CommonModContext.java#L10
Unused import `import com.paneedah.weaponlib.WeaponAttachmentAspect.ExitAttachmentModePermit;`
Unused import: src/main/java/com/paneedah/weaponlib/melee/MeleeAttachmentAspect.java#L4
Unused import `import com.paneedah.mwc.network.TypeRegistry;`
Unused import: src/main/java/com/paneedah/mwc/handlers/DebugHandler.java#L5
Unused import `import com.paneedah.weaponlib.PlayerItemInstanceRegistry;`
Unused import: src/main/java/com/paneedah/weaponlib/melee/PlayerMeleeInstance.java#L8
Unused import `import com.paneedah.weaponlib.grenade.AsyncGrenadeState;`
Unused import: src/main/java/com/paneedah/weaponlib/WeaponState.java#L3
Unused import `import com.paneedah.mwc.network.TypeRegistry;`
Unused import: src/main/java/com/paneedah/weaponlib/CommonModContext.java#L7
Unused import `import com.paneedah.weaponlib.MagazineReloadAspect.LoadPermit;`
Unused import: src/main/java/com/paneedah/weaponlib/MagazineState.java#L3
Unused import `import com.paneedah.mwc.network.TypeRegistry;`
Unused import: src/main/java/com/paneedah/weaponlib/CommonModContext.java#L9
Unused import `import com.paneedah.weaponlib.WeaponAttachmentAspect.EnterAttachmentModePermit;`
Unused import: src/main/java/com/paneedah/weaponlib/electronics/HandheldState.java#L3
Unused import `import com.paneedah.mwc.network.TypeRegistry;`
Unused import: src/main/java/com/paneedah/weaponlib/CommonModContext.java#L25
Unused import `import com.paneedah.weaponlib.state.Permit;`
Unused import: src/main/java/com/paneedah/weaponlib/CommonModContext.java#L12
Unused import `import com.paneedah.weaponlib.WeaponReloadAspect.UnloadPermit;`
Unused import: src/main/java/com/paneedah/weaponlib/MagazineReloadAspect.java#L4
Unused import `import com.paneedah.mwc.network.TypeRegistry;`
Unused import: src/main/java/com/paneedah/weaponlib/CommonModContext.java#L6
Unused import `import com.paneedah.mwc.network.TypeRegistry;`
Unused import: src/main/java/com/paneedah/weaponlib/grenade/GrenadeState.java#L3
Unused import `import com.paneedah.mwc.network.TypeRegistry;`
Unused import: src/main/java/com/paneedah/weaponlib/melee/PlayerMeleeInstance.java#L3
Unused import `import com.paneedah.mwc.network.TypeRegistry;`
Unused import: src/main/java/com/paneedah/weaponlib/CommonModContext.java#L11
Unused import `import com.paneedah.weaponlib.WeaponReloadAspect.CompoundPermit;`
Unnecessary 'return' statement: src/main/java/com/paneedah/weaponlib/grenade/GrenadeRenderer.java#L860
`return` is unnecessary as the last statement in a 'void' method
qodana
push-fixes is currently not supported with pr-mode: true in pull requests. Running Qodana with push-fixes: none.
Commented out code: src/main/java/com/paneedah/weaponlib/PlayerWeaponInstance.java#L309
Commented out code (5 lines)
Duplicated code fragment: src/main/java/com/paneedah/weaponlib/WeaponAttachmentAspect.java#L189
Duplicated code