Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instancing Rework #510

Draft
wants to merge 16 commits into
base: next
Choose a base branch
from

Merge branch 'next' into instancing-rework

f016e7b
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

Instancing Rework #510

Merge branch 'next' into instancing-rework
f016e7b
Select commit
Loading
Failed to load commit list.
GitHub Actions / Qodana for JVM completed Nov 16, 2024 in 0s

20486 new problems found by Qodana for JVM

Qodana for JVM

53 new problems were found

Inspection name Severity Problems
@NotNull/@Nullable problems 🔶 Warning 21
Unused import 🔶 Warning 19
Auto-boxing 🔶 Warning 6
Unchecked warning 🔶 Warning 2
Constant values 🔶 Warning 1
Nullability and data flow problems 🔶 Warning 1
Unnecessary 'return' statement 🔶 Warning 1
Commented out code ◽️ Notice 1
Duplicated code fragment ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 36 in src/main/java/com/paneedah/mwc/handlers/DebugHandler.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `MWC.modContext.getPlayerItemInstanceRegistry().getCacheSize()`

Check warning on line 52 in src/main/java/com/paneedah/weaponlib/PlayerWeaponInstance.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `2 + 3 * MC.gameSettings.gammaSetting`

Check warning on line 51 in src/main/java/com/paneedah/weaponlib/PlayerWeaponInstance.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `40 - MC.gameSettings.gammaSetting * 38`

Check warning on line 47 in src/main/java/com/paneedah/weaponlib/PlayerWeaponInstance.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `hasOpticalScope() ? 10 : 5`

Check warning on line 281 in src/main/java/com/paneedah/weaponlib/PlayerItemInstanceRegistry.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `entry.getIntKey()`

Check warning on line 55 in src/main/java/com/paneedah/weaponlib/PlayerWeaponInstance.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `getOpticalScopeVignetteRadius(context.getPartialTicks())`

Check notice on line 309 in src/main/java/com/paneedah/weaponlib/PlayerWeaponInstance.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Commented out code 

Commented out code (5 lines)

Check warning on line 247 in src/main/java/com/paneedah/weaponlib/ClientEventHandler.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Constant values 

Condition `mainHandHeldWeaponInstance != null` is always `true`

Check warning on line 104 in src/main/java/com/paneedah/weaponlib/compatibility/CompatibleExposureCapability.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Nullability and data flow problems 

Method invocation `getClass` may produce `NullPointerException`

Check notice on line 189 in src/main/java/com/paneedah/weaponlib/WeaponAttachmentAspect.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Duplicated code fragment 

Duplicated code

Check warning on line 25 in src/main/java/com/paneedah/mwc/commands/client/ClientCommandBase.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

@NotNull/@Nullable problems 

Not annotated parameter overrides @ParametersAreNonnullByDefault parameter

Check warning on line 60 in src/main/java/com/paneedah/mwc/commands/client/CommandPlayerItemInstanceRegistry.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

@NotNull/@Nullable problems 

Not annotated method overrides method annotated with @MethodsReturnNonnullByDefault

Check warning on line 65 in src/main/java/com/paneedah/mwc/commands/client/CommandPlayerItemInstanceRegistry.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

@NotNull/@Nullable problems 

Not annotated parameter overrides @ParametersAreNonnullByDefault parameter

Check warning on line 25 in src/main/java/com/paneedah/mwc/commands/client/ClientCommandBase.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

@NotNull/@Nullable problems 

Not annotated parameter overrides @ParametersAreNonnullByDefault parameter

Check warning on line 32 in src/main/java/com/paneedah/mwc/commands/MWCCommand.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

@NotNull/@Nullable problems 

Not annotated method overrides method annotated with @MethodsReturnNonnullByDefault

Check warning on line 32 in src/main/java/com/paneedah/mwc/commands/client/CommandPlayerItemInstanceRegistry.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

@NotNull/@Nullable problems 

Not annotated method overrides method annotated with @MethodsReturnNonnullByDefault

Check warning on line 45 in src/main/java/com/paneedah/mwc/commands/client/CommandPlayerItemInstanceRegistry.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

@NotNull/@Nullable problems 

Not annotated method overrides method annotated with @MethodsReturnNonnullByDefault

Check warning on line 32 in src/main/java/com/paneedah/mwc/commands/client/CommandPlayerItemInstanceRegistry.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

@NotNull/@Nullable problems 

Not annotated parameter overrides @ParametersAreNonnullByDefault parameter

Check warning on line 70 in src/main/java/com/paneedah/mwc/commands/client/CommandPlayerItemInstanceRegistry.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

@NotNull/@Nullable problems 

Not annotated parameter overrides @ParametersAreNonnullByDefault parameter

Check warning on line 70 in src/main/java/com/paneedah/mwc/commands/client/CommandPlayerItemInstanceRegistry.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

@NotNull/@Nullable problems 

Not annotated parameter overrides @ParametersAreNonnullByDefault parameter

Check warning on line 45 in src/main/java/com/paneedah/mwc/commands/client/CommandPlayerItemInstanceRegistry.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

@NotNull/@Nullable problems 

Not annotated parameter overrides @ParametersAreNonnullByDefault parameter

Check warning on line 50 in src/main/java/com/paneedah/mwc/commands/client/CommandPlayerItemInstanceRegistry.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

@NotNull/@Nullable problems 

Not annotated parameter overrides @ParametersAreNonnullByDefault parameter

Check warning on line 40 in src/main/java/com/paneedah/mwc/commands/client/CommandPlayerItemInstanceRegistry.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

@NotNull/@Nullable problems 

Not annotated method overrides method annotated with @MethodsReturnNonnullByDefault

Check warning on line 37 in src/main/java/com/paneedah/mwc/commands/MWCCommand.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

@NotNull/@Nullable problems 

Not annotated method overrides method annotated with @MethodsReturnNonnullByDefault

Check warning on line 50 in src/main/java/com/paneedah/mwc/commands/client/CommandPlayerItemInstanceRegistry.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

@NotNull/@Nullable problems 

Not annotated parameter overrides @ParametersAreNonnullByDefault parameter
View more details on GitHub Actions