Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lombokify #524

Merged
merged 26 commits into from
Nov 11, 2024

Fix 2

213d5c5
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Lombokify #524

Fix 2
213d5c5
Select commit
Loading
Failed to load commit list.
GitHub Actions / Qodana for JVM completed Nov 11, 2024 in 0s

20578 new problems found by Qodana for JVM

Qodana for JVM

20578 new problems were found

Inspection name Severity Problems
Unchecked warning 🔶 Warning 10585
Unnecessary 'this' qualifier 🔶 Warning 2489
Deprecated API usage 🔶 Warning 1489
Auto-boxing 🔶 Warning 731
Statement with empty body 🔶 Warning 361
Field can be local 🔶 Warning 313
Lombok @Getter may be used 🔶 Warning 276
Unused assignment 🔶 Warning 128
Auto-unboxing 🔶 Warning 125
Nullability and data flow problems 🔶 Warning 124
Non-constant field with upper-case name 🔶 Warning 114
Redundant local variable 🔶 Warning 101
Javadoc declaration problems 🔶 Warning 99
Lombok @Setter may be used 🔶 Warning 89
Questionable name 🔶 Warning 76
Constant values 🔶 Warning 68
Call to 'printStackTrace()' 🔶 Warning 36
Declaration has problems in Javadoc references 🔶 Warning 27
Possibly lossy implicit cast in compound assignment 🔶 Warning 27
Result of method call ignored 🔶 Warning 18
Deprecated member is still used 🔶 Warning 14
Dynamic regular expression can be replaced by compiled 'Pattern' 🔶 Warning 13
Link specified as plain text 🔶 Warning 13
Condition is covered by further condition 🔶 Warning 12
Mismatched query and update of collection 🔶 Warning 11
'Set' can be replaced with 'EnumSet' 🔶 Warning 11
'size() == 0' can be replaced with 'isEmpty()' 🔶 Warning 11
String concatenation as argument to 'StringBuilder.append()' call 🔶 Warning 8
Class is exposed outside of its visibility scope 🔶 Warning 7
'Map' can be replaced with 'EnumMap' 🔶 Warning 7
Octal integer 🔶 Warning 7
Suspicious collection method call 🔶 Warning 7
Vulnerable imported dependency 🔶 Warning 7
Functional expression can be folded 🔶 Warning 6
Unused import 🔶 Warning 6
Unnecessary unary minus 🔶 Warning 6
Unstable API Usage 🔶 Warning 6
Bulk operation can be used instead of iteration 🔶 Warning 6
Catch block may ignore exception 🔶 Warning 5
Variable is assigned to itself 🔶 Warning 5
Stream API call chain can be simplified 🔶 Warning 5
Dangling Javadoc comment 🔶 Warning 4
Inner class may be 'static' 🔶 Warning 4
Integer division in floating-point context 🔶 Warning 4
Copy of existing static method body 🔶 Warning 4
Manual min/max calculation 🔶 Warning 4
AutoCloseable used without 'try'-with-resources 🔶 Warning 3
Mismatched read and write of array 🔶 Warning 3
Value passed as parameter never read 🔶 Warning 3
Method is identical to its super method 🔶 Warning 3
String concatenation in loop 🔶 Warning 3
Local variable used and declared in different 'switch' branches 🔶 Warning 3
Unnecessary 'continue' statement 🔶 Warning 3
'default' not last case in 'switch' 🔶 Warning 2
Duplicate condition 🔶 Warning 2
Call math rounding with 'int' argument 🔶 Warning 2
@NotNull/@Nullable problems 🔶 Warning 2
Redundant type cast 🔶 Warning 2
Redundant operation on empty container 🔶 Warning 2
Redundant usage of unmodifiable collection wrappers 🔶 Warning 2
Method does not call super method 🔶 Warning 2
Call to 'Arrays.asList()' with too few arguments 🔶 Warning 1
Caught exception is immediately rethrown 🔶 Warning 1
Redundant 'Collection.addAll()' call 🔶 Warning 1
'static' method declared 'final' 🔶 Warning 1
Call to 'toString()' on array 🔶 Warning 1
Infinite recursion 🔶 Warning 1
Method name same as class name 🔶 Warning 1
'protected' member in 'final' class 🔶 Warning 1
String comparison using '==', instead of 'equals()' 🔶 Warning 1
'String.equals()' can be replaced with 'String.isEmpty()' 🔶 Warning 1
Suspicious variable/parameter name combination 🔶 Warning 1
Minimum 'switch' branches 🔶 Warning 1
Unary plus 🔶 Warning 1
Constant values ◽️ Notice 1351
Commented out code ◽️ Notice 1005
Duplicated code fragment ◽️ Notice 679
'if' statement with identical branches or common parts ◽️ Notice 9
Method can be extracted ◽️ Notice 7
Multiple occurrences of the same expression ◽️ Notice 4
Duplicate branches in 'switch' ◽️ Notice 3
Non-strict inequality '>=' or '<=' can be replaced with '==' ◽️ Notice 1

☁️ View the detailed Qodana report

Detected 18 dependencies

Third-party software list

This page lists the third-party software dependencies used in Modern Warfare Cubed

Dependency Version Licenses
commons-codec 1.10 Apache-2.0
commons-compress 1.8.1 Apache-2.0
commons-io 2.5 Apache-2.0
commons-lang3 3.5 Apache-2.0
commons-logging 1.1.3 Apache-2.0
groovyscript 1.2.0-hotfix1 MIT
httpclient 4.3.3 Apache-2.0
httpcore 4.3.2 Apache-2.0
CC-BY-2.5
icu4j-core-mojang 51.2 IBM-ICU
java-objc-bridge 1.0.0 Apache-2.0
jline 3.5.1 BSD-3-Clause
jopt-simple 5.0.3 MIT
log4j-api 2.17.1 Apache-2.0
log4j-core 2.17.1 Apache-2.0
lombok 1.18.32 BSD-3-CLAUSE-NO-TRADEMARK
MIT
maven-artifact 3.5.3 Apache-2.0
plexus-utils 3.1.0 Apache-2.0
vecmath 1.5.2 GPL-2.0-only
ORACLE-OPENJDK-EXCEPTION-2.0
Contact Qodana team

Contact us at [email protected]

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 225 in src/main/java/com/paneedah/weaponlib/CommonEventHandler.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Call to 'Arrays.asList()' with too few arguments 

Call to `asList()` with only one argument

Check warning on line 40 in src/main/java/com/paneedah/mwc/items/guns/M1GarandFactory.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `0.6f`

Check warning on line 206 in src/main/java/com/paneedah/weaponlib/animation/MultipartRenderStateManager.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `currentTime`

Check warning on line 342 in src/main/java/com/paneedah/weaponlib/animation/DebugPositioner.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `partPosition.zRotation`

Check warning on line 293 in src/main/java/com/paneedah/weaponlib/animation/jim/AnimationData.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `timestamp`

Check warning on line 569 in src/main/java/com/paneedah/weaponlib/ClientEventHandler.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `entityID`

Check warning on line 34 in src/main/java/com/paneedah/weaponlib/animation/jim/SingleAnimation.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `time`

Check warning on line 44 in src/main/java/com/paneedah/mwc/items/guns/turretgunFactory.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `0.1f`

Check warning on line 48 in src/main/java/com/paneedah/mwc/items/guns/P226Factory.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `0.6f`

Check warning on line 321 in src/main/java/com/paneedah/weaponlib/command/DebugCommand.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `false`

Check warning on line 38 in src/main/java/com/paneedah/mwc/items/guns/M79Factory.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `0.101f`

Check warning on line 41 in src/main/java/com/paneedah/mwc/items/guns/DP28Factory.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `0.6f`

Check warning on line 66 in src/main/java/com/paneedah/weaponlib/animation/jim/AnimationData.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `time`

Check warning on line 28 in src/main/java/com/paneedah/weaponlib/vehicle/VehicleTransmissionStrategy.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `0f`

Check warning on line 46 in src/main/java/com/paneedah/mwc/items/guns/HK_P12Factory.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `0.1f`

Check warning on line 61 in src/main/java/com/paneedah/mwc/items/grenade/FuseGrenadeFactory.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `-0.025f`

Check warning on line 46 in src/main/java/com/paneedah/mwc/items/guns/M249Factory.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `0.15f`

Check warning on line 41 in src/main/java/com/paneedah/weaponlib/PipelineShaderGroupSourceProvider.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `10f`

Check warning on line 48 in src/main/java/com/paneedah/mwc/items/guns/KragJorgensenFactory.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `0.08f`

Check warning on line 46 in src/main/java/com/paneedah/mwc/items/guns/KrissVectorFactory.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `0.5f`

Check warning on line 271 in src/main/java/com/paneedah/weaponlib/sound/JSoundEngine.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `x`

Check warning on line 61 in src/main/java/com/paneedah/mwc/items/grenade/FuseGrenadeFactory.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `0.2f`

Check warning on line 42 in src/main/java/com/paneedah/mwc/items/grenade/SmokeGrenadeFactory.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `0.06f`

Check warning on line 45 in src/main/java/com/paneedah/mwc/items/guns/G3Factory.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `0.6f`

Check warning on line 45 in src/main/java/com/paneedah/mwc/items/guns/M32MGLFactory.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Auto-boxing 

Auto-boxing `0.101f`
View more details on GitHub Actions