Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some new configs #530

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

enableStatusMessages and bulletHitParticleMult configs

c2a9651
Select commit
Loading
Failed to load commit list.
Open

Add some new configs #530

enableStatusMessages and bulletHitParticleMult configs
c2a9651
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (next) failed Nov 13, 2024 in 35s

CodeScene PR Check

โŒ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.13 (6.23 -> 6.10)

  • Declining Code Health: 3 findings(s) ๐Ÿšฉ

  • Affected Hotspots: 1 files(s) ๐Ÿ”ฅ

View detailed results in CodeScene

Details

๐Ÿšฉ Declining Code Health (highest to lowest):

  • Bumpy Road Ahead Weapon.java: changeFireMode ๐Ÿ”ฅ
  • Bumpy Road Ahead Weapon.java: incrementZoom ๐Ÿ”ฅ
  • Bumpy Road Ahead Weapon.java: decrementZoom ๐Ÿ”ฅ

Annotations

Check notice on line 1 in src/main/java/com/paneedah/weaponlib/Weapon.java

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (next)

โ„น Getting worse: Lines of Code in a Single File

The lines of code increases from 1053 to 1059, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.

Check warning on line 1414 in src/main/java/com/paneedah/weaponlib/Weapon.java

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (next)

โŒ New issue: Bumpy Road Ahead

changeFireMode has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 1484 in src/main/java/com/paneedah/weaponlib/Weapon.java

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (next)

โŒ New issue: Bumpy Road Ahead

incrementZoom has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 1512 in src/main/java/com/paneedah/weaponlib/Weapon.java

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (next)

โŒ New issue: Bumpy Road Ahead

decrementZoom has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check notice on line 1 in src/main/java/com/paneedah/weaponlib/WeaponFireAspect.java

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (next)

โ„น Getting worse: Overall Code Complexity

The mean cyclomatic complexity increases from 5.50 to 5.58, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.