Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Updates to groups #243

Merged
merged 3 commits into from
Dec 12, 2023
Merged

🐛 Updates to groups #243

merged 3 commits into from
Dec 12, 2023

Conversation

ascpial
Copy link
Contributor

@ascpial ascpial commented Aug 30, 2023 •
edited
Loading

Cette PR résout différents problèmes avec le module groups :

  • certaines variables n'ont pas été renommées lors du refactor ;
  • des commandes de configurations n'ont pas été correctement déplacée lors d'un autre refactor ;
  • des erreurs liées au plugin groups ont étés déplacées depuis le cœur dans le plugin.

Fixes #232.
Fixes #255.

Checklist :

  • Approuvé par au moins un membre de l'équipe @Curiosity-org/gipsy
  • Testé par au moins un membre de l'équipe @Curiosity-org/gipsy
  • PyLint est content

@ascpial ascpial added bug Something isn't working core plugin labels Aug 30, 2023
@Aeris1One Aeris1One requested a review from a team November 1, 2023 10:23
Aeris1One
Aeris1One approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@Aeris1One Aeris1One left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ZRunner
ZRunner reviewed Nov 2, 2023
View reviewed changes
plugins/groups/groups.py Outdated Show resolved Hide resolved
plugins/groups/groups.py Show resolved Hide resolved
plugins/groups/groups.py Outdated Show resolved Hide resolved
@ascpial
Copy link
Contributor Author

ascpial commented Nov 6, 2023

Non testé, Discord est down.

@ascpial ascpial mentioned this pull request Dec 12, 2023
Closed
@ZRunner ZRunner merged commit 031910a into beta Dec 12, 2023
3 of 5 checks passed
@ZRunner ZRunner deleted the fix-groups branch December 12, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZRunner ZRunner ZRunner left review comments

@Aeris1One Aeris1One Aeris1One approved these changes

Assignees

@ascpial ascpial

Labels
bug Something isn't working core plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edition of group_channel_category config doesn't work Plugins/Groups cannot rename group
3 participants
@ascpial @Aeris1One @ZRunner