fix dart where no project is specified #1571
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul <[email protected]>
Signed-off-by: Paul <[email protected]>
|
@paul-doherty Thank you for the fix. What do you think about my PR, where I am using the information from the pubspec.yaml for the parent? |
|
Ah apologies, I missed your PR. Also apologies for causing you work. That looks great. Thanks for that. I'll close this one as your approach is much better. |
|
Thank you so much for checking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1564
Fix: package type to pub
Fix: creating finding parentComponent to use default if no options passed
@malice00 i dont think I can manually rerun those tests