-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use purl as bomref #84
Conversation
The metadata component is the thing being analyzed. However, normally the thing being analyzed is an application being built that uses CocoaPods as its dependency manager. So it should maybe have something like an The purl specification specifically says
This specific set of code is not going to work for the metadata component. Maybe if the metadata component's type is |
I'll look into adding a purl type as an option that defaults to |
After looking at the code some more - I think we can infer the package type from the specified component type. The purl type should be ' generic ' if the component type is anything but |
Signed-off-by: Jeremy Long <[email protected]>
Signed-off-by: Jeremy Long <[email protected]>
Signed-off-by: Jeremy Long <[email protected]>
Signed-off-by: Jeremy Long <[email protected]>
Signed-off-by: Jeremy Long <[email protected]>
Signed-off-by: Jeremy Long <[email protected]>
Signed-off-by: Jeremy Long <[email protected]>
Signed-off-by: Jeremy Long <[email protected]>
Signed-off-by: Jeremy Long <[email protected]>
Signed-off-by: Jeremy Long <[email protected]>
Signed-off-by: Jeremy Long <[email protected]>
Signed-off-by: Jeremy Long <[email protected]>
Signed-off-by: Jeremy Long <[email protected]>
Signed-off-by: Jeremy Long <[email protected]>
Signed-off-by: Jeremy Long <[email protected]>
Signed-off-by: Jeremy Long <[email protected]>
@macblazer I think this is ready for your re-review now. I believe I have addressed your concerns about using the package type of cocopods with 9fda73d and I have added a test with ce9bcaf. Yes, this is abusing the 'type' slightly, but I felt this was better than upping the parameter count to 7. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than the one duplicate function that seems unused. I like this ability to read the podspec file and generate the purl of the thing being analyzed if it is a Pod.
Signed-off-by: Jeremy Long <[email protected]>
For the metadata component it would be great if we had a purl. As such, if we just make the bomref a purl we can use the value for both the bomref and the purl.