Fix switch default Signed-off-by: Carolina Oliveira <61292734+Carolin…

…[email protected]> Signed-off-by: Carolina Oliveira <[email protected]>
CycloneDX · Sep 9, 2024 · 7eada19 · 7eada19
1 parent 515f464
commit 7eada19
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/src/CycloneDX.Spdx.Interop/Converters/v2_3/Helpers/Component/Checksums.cs b/src/CycloneDX.Spdx.Interop/Converters/v2_3/Helpers/Component/Checksums.cs
@@ -119,6 +119,8 @@ public static List<Checksum> GetSpdxChecksums(this Component component)
                                 ChecksumValue = hash.Content,
                             });
                             break;
+                        default:
+                            break;
                     }
                 }
             }
@@ -164,6 +166,8 @@ public static List<Checksum> GetSpdxChecksums(this Component component)
                                 ChecksumValue = checksum.Value,
                             });
                             break;
+                        default:
+                            break;
                     }
                 }
             }
@@ -280,6 +284,8 @@ public static void AddSpdxChecksums(this Component component, List<Checksum> che
                         case ChecksumAlgorithm.ADLER32:
                             component.Properties.AddSpdxElement(PropertyTaxonomy.CHECKSUM_ADLER32, checksum.ChecksumValue);
                             break;
+                        default:
+                            break;
                     }
                 }
             }

diff --git a/src/CycloneDX.Spdx.Interop/Converters/v2_3/Helpers/Component/ExternalRefs.cs b/src/CycloneDX.Spdx.Interop/Converters/v2_3/Helpers/Component/ExternalRefs.cs
@@ -71,6 +71,8 @@ public static List<ExternalRef> GetSpdxExternalRefs(this Component component)
                             extRef.ReferenceCategory = ExternalRefCategory.PACKAGE_MANAGER;
                             extRef.ReferenceType = "purl";
                             break;
+                        default:
+                            break;
                     }
                     //TODO add this back in once the SPDX JSON schema is fixed https://github.com/spdx/spdx-spec/issues/612
                     //TODO and write corresponding code in AddExternalRefsToCDX
@@ -103,15 +105,8 @@ public static void AddSpdxExternalRefs(this Component component, List<ExternalRe
                     string refPropName = null;
                     if (extRef.ReferenceCategory == ExternalRefCategory.SECURITY)
                     {
-                        switch (extRef.ReferenceType)
-                        {
-                            case "cpe22Type":
-                                refPropName = PropertyTaxonomy.EXTERNAL_REFERENCE_SECURITY_CPE22;
-                                break;
-                            case "cpe23Type":
-                                refPropName = PropertyTaxonomy.EXTERNAL_REFERENCE_SECURITY_CPE23;
-                                break;
-                        }
+                        if(extRef.ReferenceType == "cpe22Type") { refPropName = PropertyTaxonomy.EXTERNAL_REFERENCE_SECURITY_CPE22; }
+                        else if(extRef.ReferenceType == "cpe23Type"){ refPropName = PropertyTaxonomy.EXTERNAL_REFERENCE_SECURITY_CPE23; } 
                     }
                     else if (extRef.ReferenceCategory == ExternalRefCategory.PACKAGE_MANAGER)
                     {
@@ -132,6 +127,8 @@ public static void AddSpdxExternalRefs(this Component component, List<ExternalRe
                             case "purl":
                                 refPropName = PropertyTaxonomy.EXTERNAL_REFERENCE_PACKAGE_MANAGER_PURL;
                                 break;
+                            default:
+                                break;
                         }
                     }
                     else if (extRef.ReferenceCategory == ExternalRefCategory.OTHER)