Support 1.6 spec #556
Support 1.6 spec #556
Conversation
thesurlydev
force-pushed
the
support-1.6-spec
branch
from
576fb8d
to
64054da
Compare
| @@ -80,7 +80,7 @@ public abstract class BaseCycloneDxMojo extends AbstractMojo { | |||
| * | |||
| * @since 2.1.0 | |||
| */ | |||
| @Parameter(property = "schemaVersion", defaultValue = "1.6", required = false) | |||
| @Parameter(property = "schemaVersion", defaultValue = "1.5", required = false) | |||
There was a problem hiding this comment.
until now, default schema version was latest supported: why doing that? is really consistency with Gradle plugin a good reason?
There was a problem hiding this comment.
I don't have a strong opinion but thought there might be precedence for keeping the default one version behind. Maybe this would be a good addition to the missing CONTRIBUTING.md document (#557) :)
There was a problem hiding this comment.
I believe we can set CycloneDX 1.6 as the default in version 2.9.x. @stevespringett, what do you think?
There was a problem hiding this comment.
please drop this commit and squash the others
There was a problem hiding this comment.
I have no objection to updating default to 1.6. As @hboutemy observes, this maintains consistent behaviour with previous releases. The 1.6 spec was released 6 months ago. It will seem like no time at all before 1.7 is out!
There was a problem hiding this comment.
Agreed that 1.6 should be the default. Its been out long enough and is a higher-quality spec over v1.5.
thesurlydev
force-pushed
the
support-1.6-spec
branch
from
64054da
to
e41f66c
Compare
Signed-off-by: Shane Witbeck <[email protected]>
thesurlydev
force-pushed
the
support-1.6-spec
branch
from
c439ca2
to
567818d
Compare
|
@hboutemy I've made 1.6 the default and squashed the commits. |
|
@hboutemy Can this be merged now? |
|
back home, merged: thanks a lot @thesurlydev |
This PR adds support for the 1.6 specification. Closes issue #489