Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prevent type confusion #438

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Dec 2, 2023

symfony/console v7 introduced return types.
composer does not follow those, yet.
this causes errors: https://github.com/CycloneDX/cyclonedx-php-composer/actions/runs/7066431487/job/19238277833#step:9:19

PHP Fatal error:  Declaration of Composer\Command\InitCommand::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Component\Console\Command\Command::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int in /home/runner/work/cyclonedx-php-composer/cyclonedx-php-composer/vendor/composer/composer/src/Composer/Command/InitCommand.php on line 85

here is the workaound: dont use v7 of symfony/console

@jkowalleck jkowalleck requested a review from a team as a code owner December 2, 2023 09:01
@jkowalleck jkowalleck force-pushed the fix-composer-console-compat branch from de1e4c1 to 38654db Compare December 2, 2023 09:02
Signed-off-by: Jan Kowalleck <[email protected]>
Copy link

codacy-production bot commented Dec 2, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5857f13) 422 402 95.26%
Head commit (c33ed1f) 422 (+0) 402 (+0) 95.26% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#438) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@jkowalleck jkowalleck force-pushed the fix-composer-console-compat branch from 38654db to c33ed1f Compare December 2, 2023 09:04
@jkowalleck jkowalleck merged commit b01ae9e into master Dec 2, 2023
32 of 33 checks passed
@jkowalleck jkowalleck deleted the fix-composer-console-compat branch December 2, 2023 09:06
jkowalleck added a commit that referenced this pull request Mar 11, 2024
follwoup of #438

Signed-off-by: Jan Kowalleck <[email protected]>
jkowalleck added a commit that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant