Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pollish evidence gathering #1312

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix: pollish evidence gathering #1312

merged 1 commit into from
Oct 8, 2024

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Oct 7, 2024

followup of #1309

@jkowalleck jkowalleck requested a review from a team as a code owner October 7, 2024 22:53
@@ -1569,10 +1549,6 @@ exports[`integration feature: component evidence generated xml file: dist/.bom/b
</externalReferences>
<evidence>
<licenses>
<license>
<name>file: CopyrightNotice.txt</name>
Copy link
Member Author

@jkowalleck jkowalleck Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the pattern for Notice was wrong - so these files were false-positives.

@jkowalleck jkowalleck changed the title refactor: pollish evidence gathering fix: pollish evidence gathering Oct 7, 2024
Copy link

codacy-production bot commented Oct 7, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.60% 94.44% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (18e7034) 672 630 93.75%
Head commit (3e653be) 657 (-15) 612 (-18) 93.15% (-0.60%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1312) 72 68 94.44%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jkowalleck jkowalleck force-pushed the feat/evidence_pollish branch 6 times, most recently from 18db1df to f792a92 Compare October 8, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant