Skip to content

Commit

Permalink
docs: docsge fix title in <meta> elements (#572)
Browse files Browse the repository at this point in the history 
current docsgen result in broken metatags:
```html
    <meta name="twitter:title" content=""CycloneDX v1.6 Protobuf Reference""/>
    <meta name="twitter:image" content="https://cyclonedx.org/images/CycloneDX-Social-Card.png"/>
    <meta name="twitter:description" content=""CycloneDX v1.6 Protobuf Reference""/>
    <meta name="description" content=""CycloneDX v1.6 Protobuf Reference""/>
    <meta property="og:description" content=""CycloneDX v1.6 Protobuf Reference""/>
    <meta property="og:title" content=""CycloneDX v1.6 Protobuf Reference""/>
```

this PR fixes this

Signed-off-by: Jan Kowalleck <[email protected]>
  • Loading branch information
@jkowalleck
jkowalleck authored Jan 11, 2025
1 parent a43e6f7 commit cf1ffa0
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
12 changes: 6 additions & 6 deletions docgen/json/templates/cyclonedx/base.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@
<meta charset="UTF-8"/>
<meta name="twitter:card" content="summary_large_image"/>
<meta name="twitter:site" content="@CycloneDX_Spec"/>
<meta name="twitter:title" content="${quotedTitle}"/>
<meta name="twitter:title" content="${title}"/>
<meta name="twitter:image" content="https://cyclonedx.org/images/CycloneDX-Social-Card.png"/>
<meta name="twitter:description" content="${quotedTitle}"/>
<meta name="description" content="${quotedTitle}"/>
<meta property="og:description" content="${quotedTitle}"/>
<meta property="og:title" content="${quotedTitle}"/>
<meta name="twitter:description" content="${title}"/>
<meta name="description" content="${title}"/>
<meta property="og:description" content="${title}"/>
<meta property="og:title" content="${title}"/>
<meta property="og:locale" content="en_US"/>
<meta property="og:type" content="website" />
<meta property="og:image" content="https://cyclonedx.org/images/CycloneDX-Social-Card.png" />
Expand Down Expand Up @@ -93,4 +93,4 @@ <h1>{{ title }}</h1>
-->

</body>
</html>
</html>
10 changes: 5 additions & 5 deletions docgen/proto/templates/html.tmpl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ https://github.com/pseudomuto/protoc-gen-doc/blob/master/resources/html.tmpl
<meta charset="UTF-8"/>
<meta name="twitter:card" content="summary_large_image"/>
<meta name="twitter:site" content="@CycloneDX_Spec"/>
<meta name="twitter:title" content="${quotedTitle}"/>
<meta name="twitter:title" content="${title}"/>
<meta name="twitter:image" content="https://cyclonedx.org/images/CycloneDX-Social-Card.png"/>
<meta name="twitter:description" content="${quotedTitle}"/>
<meta name="description" content="${quotedTitle}"/>
<meta property="og:description" content="${quotedTitle}"/>
<meta property="og:title" content="${quotedTitle}"/>
<meta name="twitter:description" content="${title}"/>
<meta name="description" content="${title}"/>
<meta property="og:description" content="${title}"/>
<meta property="og:title" content="${title}"/>
<meta property="og:locale" content="en_US"/>
<meta property="og:type" content="website" />
<meta property="og:image" content="https://cyclonedx.org/images/CycloneDX-Social-Card.png" />
Expand Down

0 comments on commit cf1ffa0

Please sign in to comment.