Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Curios support #30

Draft
wants to merge 6 commits into
base: master-1.16
Choose a base branch
from
Draft

Conversation

met4000
Copy link

@met4000 met4000 commented Apr 25, 2022

Related to #2 on InTu-Compat

@CLAassistant
Copy link

CLAassistant commented Apr 25, 2022

CLA assistant check
All committers have signed the CLA.

@rubensworks
Copy link
Member

@met4000 I just noticed this one is still in draft-mode.
Is this still a WIP? Or could it be closed?

@met4000
Copy link
Author

met4000 commented Aug 30, 2024

I believe it's 90% done (see also CyclopsMC/IntegratedTunnels#254) - it's just missing the support for enums in aspect configs to make it more feasible to support languages other than english (and have a more user friendly ui), although this was for 1.16 so the updates since then might mean extra changes are needed.
It's still on my todo list, but if it wasn't evident by how long it's been since I initially worked on it, it's not near the top and I've been putting it off because of needing to learn how to interact with the GUI side of things rather than just making functional changes.

If the enum support still needs to be added before merging then these two PRs can always get closed and reopened later when/if something happens.

@rubensworks
Copy link
Member

it's just missing the support for enums in aspect configs to make it more feasible to support languages other than english (and have a more user friendly ui)
If the enum support still needs to be added before merging then these two PRs can always get closed and reopened later when/if something happens.

Given that adding enum support is non-trivial, perhaps we can go forward with a custom workaround for now so we can already get this one in. We can add a TODO in the code to remove the workaround once enum support is added.
Does this make sense?

@met4000
Copy link
Author

met4000 commented Sep 3, 2024

Yeah, fine by me - I don't have the old dev environment anymore but in the next few weeks I should have a spare weekend when I can set up a dev env, update this for a newer mc version, and get it to the point where it can be initially merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants