-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Curios support #30
base: master-1.16
Are you sure you want to change the base?
Conversation
@met4000 I just noticed this one is still in draft-mode. |
I believe it's 90% done (see also CyclopsMC/IntegratedTunnels#254) - it's just missing the support for enums in aspect configs to make it more feasible to support languages other than english (and have a more user friendly ui), although this was for 1.16 so the updates since then might mean extra changes are needed. If the enum support still needs to be added before merging then these two PRs can always get closed and reopened later when/if something happens. |
Given that adding enum support is non-trivial, perhaps we can go forward with a custom workaround for now so we can already get this one in. We can add a TODO in the code to remove the workaround once enum support is added. |
Yeah, fine by me - I don't have the old dev environment anymore but in the next few weeks I should have a spare weekend when I can set up a dev env, update this for a newer mc version, and get it to the point where it can be initially merged. |
Related to #2 on InTu-Compat