Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unity.TextMeshPro Extensions #285

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TORISOUP
Copy link
Contributor

@TORISOUP TORISOUP commented Jan 6, 2025

Added Observable extension to TextMeshPro in Unity.

I am following the policy in #269 for implementation.
It is expected that there will be conflicts after the #269 merge. In that case, I will push a fix commit separately.

@neuecc
Copy link
Member

neuecc commented Jan 8, 2025

Thank you, this looks good.
I think using "name" instead of GUID for references might be better - what do you think?

Sorry for the delayed merge.
I will process them sequentially.

@TORISOUP
Copy link
Contributor Author

TORISOUP commented Jan 8, 2025

Thank you for the feedback.
I agree that using "name" for references seems like a better.

I'll create a modified commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants