Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

game: options: chose render driver with command-line parameter #938

Merged
merged 1 commit into from
May 19, 2022
Merged

game: options: chose render driver with command-line parameter #938

merged 1 commit into from
May 19, 2022

Conversation

dalerank
Copy link
Contributor

task: #330

@sonarcloud
Copy link

sonarcloud bot commented May 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

SimplyLiz
SimplyLiz approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@SimplyLiz SimplyLiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SimplyLiz
Copy link
Contributor

We should parse command line parameters in one place though. #940

@SimplyLiz SimplyLiz merged commit bce41c5 into CytopiaTeam:master May 19, 2022
@SimplyLiz SimplyLiz linked an issue May 24, 2022 that may be closed by this pull request
Chose render driver with command-line parameter #330
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimplyLiz SimplyLiz SimplyLiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chose render driver with command-line parameter
2 participants
@dalerank @SimplyLiz