Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #346 scan robust to corrput file #426

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix #346 scan robust to corrput file #426

merged 1 commit into from
Aug 28, 2024

Conversation

d-chambers
Copy link
Contributor

Description

This PR makes dc.scan robust to corrupted files whose format is determinable but when they are scanned they HDF5 raises an OSError. See #346.

closes #346.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

@d-chambers
Copy link
Contributor Author

Hey @ahmadtourei,

It looks like the issue is back. I guess we need to disable the cache for macos.

@ahmadtourei
Copy link
Collaborator

Hey @ahmadtourei,

It looks like the issue is back. I guess we need to disable the cache for macos.

Ah I see. Yes, I agree.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.84%. Comparing base (2e911d1) to head (250d875).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #426   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         112      112           
  Lines        9032     9037    +5     
=======================================
+ Hits         9018     9023    +5     
  Misses         14       14           
Flag Coverage Δ
unittests 99.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-chambers d-chambers merged commit 8fa6680 into master Aug 28, 2024
15 checks passed
@d-chambers d-chambers deleted the fix_346 branch August 28, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scan not robust to corrupted file
2 participants