fixes not seeing changes to the type of a field #60
Conversation
|
Can you fix the tests and make a regression test? Thanks a lot |
|
I'll correct the tests when I get a chance. |
|
The psql and sqlite3 tests are passing, but the mysql and mysql2 ones don't fully pass. I don't really understand what about my change messed it up. Maybe some of these errors are just because of my environment. I will further into it. |
burnt43
force-pushed
the
master
branch
2 times, most recently
from
e340ae4
to
685fed2
Compare
|
@DAddYE, when I look at the output of the build from Travis CI, it seems something might be messed up with bundler on whatever server those tests run on. It is not even running the tests. Its failing at bundler install. I actually reverted my changes in this PR so the Travis CI would attempt to run them again and even with my change removed it still failed at installing mini_record -v 0.4.6. I can run the tests fine myself as you can see from below. I think maybe bundler needs to be updated on the test server. [jcarson@burnt43 mini_record]$ rake test /usr/local/bin/ruby -I"lib:test" -I"/usr/local/lib/ruby/1.9.1" "/usr/local/lib/ruby/1.9.1/rake/rake_test_loader.rb" "test/test_mini_record.rb" Testing with DB=sqlite Run options: --seed 53860 # Running: .........S...............SSSSSSS..S.S.S..SS..SS.. Finished in 4.313712s, 11.3591 runs/s, 59.8093 assertions/s. 49 runs, 258 assertions, 0 failures, 0 errors, 15 skips You have skipped tests. Run with --verbose for details. Also to note, I noticed from successful passed Travis CI builds that it only runs the sqlite3 tests. I ran the test from the other 3 adapters and found that psql passes, mysql fails on some, and mysql2 fails on some, but I guess this was not caught because it is only running sqlite3 test |
|
@burnt43, CI fixed, please resubmit your PR |
|
@sleewoo, done deal |
closes #59.