Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EYQB-233: Updated the slot to have a system identity which can then b… #186

Merged
merged 2 commits into from
Jun 11, 2024
Merged

EYQB-233: Updated the slot to have a system identity which can then b… #186

merged 2 commits into from
Jun 11, 2024

Conversation

sam-c-dfe
Copy link
Collaborator

Description

Updated the slot to have a system identity which can then be used to create an access policy for KeyVault

Ticket number (if applicable) - EYQB-233

How Has This Been Tested?

N/A

Screenshots

N/A

Checklist:

  • My code follows the standards used within this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests (Unit, E2E) that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@sam-c-dfe
EYQB-233: Updated the slot to have a system identity which can then b…
81654c9 
…e used to create an access policy for KeyVault
@github-actions GitHub Actions
Copy link
Contributor

Code Coverage

Package Line Rate Branch Rate Health
Dfe.EarlyYearsQualification.Content 84% 91% ➖
Dfe.EarlyYearsQualification.Mock 91% 100% ✔
Dfe.EarlyYearsQualification.Web 98% 85% ✔
Summary 90% (1098 / 1217) 89% (121 / 136) ✔

Minimum allowed line rate is 75%

@sam-c-dfe sam-c-dfe merged commit f6e6e08 into main Jun 11, 2024
@sam-c-dfe sam-c-dfe deleted the feature/eyqb-233-update-slot-permissions branch June 11, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielClarkeEducation DanielClarkeEducation DanielClarkeEducation approved these changes

@RobertGHippo RobertGHippo Awaiting requested review from RobertGHippo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sam-c-dfe @DanielClarkeEducation