Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/govuk frontend package implementation #3

Conversation

DanielClarkeEducation
Copy link
Collaborator

Description

Added Gov UK frontend package found here

Ticket number (if applicable)

How Has This Been Tested?

Just manual testing so far as is still a draft

Screenshots

Please include screenshots if applicable.

Checklist:

  • My code follows the standards used within this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests (Unit, E2E) that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@@ -20,6 +20,7 @@ public async Task<LandingPage> GetLandingPage()
var landingPageContent = landingPageEntries.First();
var htmlRenderer = new HtmlRenderer();
htmlRenderer.AddRenderer(new UnorderedListRenderer() { Order = 10 });
htmlRenderer.AddRenderer(new Dfe.EarlyYearsQualification.Content.Renderers.ParagraphRenderer() { Order = 10 });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
htmlRenderer.AddRenderer(new Dfe.EarlyYearsQualification.Content.Renderers.ParagraphRenderer() { Order = 10 });
htmlRenderer.AddRenderer(new ParagraphRenderer() { Order = 11 });

@DanielClarkeEducation DanielClarkeEducation deleted the feature/govuk-frontend-package-implementation branch January 30, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants