Enable filtering of request query strings using ActiveSupport::ParameterFilter.
#111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steventux
force-pushed
the
web-request-query-filtering
branch
from
8b0ad22
to
9eabb6a
Compare
Adds a configurable web_request event query string filter via ActiveSupport::ParameterFilter mechanism.
steventux
force-pushed
the
web-request-query-filtering
branch
from
9eabb6a
to
23459aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PII can leak into DfE analytics if present in the request query string, a common case is search parameters using personal details.
This PR adds the ability to enable web request event query filtering using the standard Rails parameter filter mechanism via the
DfE::Analytics.filter_web_request_eventsconfiguration value.See: DFE-Digital/access-your-teaching-qualifications@5941285 for a common workaround currently being used in services to mitigate this.
It would be preferable not to replicate this workaround on a per-service basis.