Skip to content

Commit

Permalink
add ADR for Cypress rework
Browse files Browse the repository at this point in the history
  • Loading branch information
CMurrell148 committed Oct 8, 2024
1 parent 75e3137 commit 1681075
Showing 1 changed file with 32 additions and 0 deletions.
32 changes: 32 additions & 0 deletions docs/adrs/0017-create-new-cypress-suite.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# 16. Create a new Cypress test suite to replace both the old Cypress suite and old Playwright suite

**Date**: 2024-10-08

## Status

Accepted

## Context

Check failure on line 9 in docs/adrs/0017-create-new-cypress-suite.md

View workflow job for this annotation

GitHub Actions / mdlint

Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Context"]
The old Cypress suite was not quite fit for purpose for both test and development use cases.

The tests used a journey based test approach which does not quite fit the flow and layout of FIAT. It also did not fully replace/encompass that which existed before it in the Playwright tests.

From a test perspective the old suite did not quite hit the target of being easy to understand from someone from a test background who may be less experienced with coding and more developer based knowledge sets.

From a dev perspective the old suite did not quite give them the confidence that their code was being adequately tested.


Check failure on line 18 in docs/adrs/0017-create-new-cypress-suite.md

View workflow job for this annotation

GitHub Actions / mdlint

Multiple consecutive blank lines [Expected: 1; Actual: 2]
## Decision

Check failure on line 19 in docs/adrs/0017-create-new-cypress-suite.md

View workflow job for this annotation

GitHub Actions / mdlint

Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Decision"]
The decision was to create a new Cypress suite that both encompassed the old Playwright coverage and create a Cypress suite created from the ground up with a test mindset behind each part of said suite.

This was then worked on my Test in close tandem with the Dev team ensuring that no old coverage was missed and that we also captured all requirements from test and dev.

We also adapted the pipeline to be more in line with the new suite as previously we had deployment tests and the UI tests but we landed on just having a dedicated UI test run.

As part of the work we also assessed the previously used docker/faker system and moved this away to pointing at test and dev as they are closer to what the live product is like and give us more confidence rather than running against hard coded/faker data.


Check failure on line 28 in docs/adrs/0017-create-new-cypress-suite.md

View workflow job for this annotation

GitHub Actions / mdlint

Multiple consecutive blank lines [Expected: 1; Actual: 2]
## Consequences

Check failure on line 29 in docs/adrs/0017-create-new-cypress-suite.md

View workflow job for this annotation

GitHub Actions / mdlint

Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Consequences"]
The end result was a robust suit of over 60 tests that not only captured old covered functionality but expanded upon and brought more confidence to the tech team.

We now also have a good jumping off point to create new tests in as the sprints go forward.

Check failure on line 32 in docs/adrs/0017-create-new-cypress-suite.md

View workflow job for this annotation

GitHub Actions / mdlint

Files should end with a single newline character

0 comments on commit 1681075

Please sign in to comment.