Skip to content

Commit

Permalink
Improve queries in placements policies
Browse files Browse the repository at this point in the history
  • Loading branch information
Jamie committed Oct 7, 2024
1 parent c5eae01 commit 6184ef8
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion app/policies/placements/mentor_policy.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ class Scope < ApplicationPolicy::Scope
def resolve
return scope if user.support_user?

scope.where(id: Placements::MentorMembership.select(:mentor_id).where(school: user.schools))
scope.where(id: user.schools.joins(:mentor_memberships).select(:mentor_id))
end
end
end
2 changes: 1 addition & 1 deletion app/policies/provider_policy.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ class Scope < ApplicationPolicy::Scope
def resolve
return scope if user.support_user?

scope.where(id: Placements::Partnership.select(:provider_id).where(school: user.schools))
scope.where(id: user.schools.joins(:partnerships).select(:provider_id))
end
end
end
2 changes: 1 addition & 1 deletion app/policies/school_policy.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ class Scope < ApplicationPolicy::Scope
def resolve
return scope if user.support_user?

scope.where(id: Placements::Partnership.select(:school_id).where(provider: user.providers))
scope.where(id: user.providers.joins(:partnerships).select(:school_id))
end
end
end

0 comments on commit 6184ef8

Please sign in to comment.