Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sandbox DSI configuration #1064

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Nitemaeric
Copy link
Contributor

@Nitemaeric Nitemaeric commented Sep 25, 2024

Context

We want to configure the Sandbox environment to work as it would in production. APIs will all read in real-life data from production APIs.

The difference for Sandbox is that it should not submit real information to external partners, such as the ESFA.

Changes proposed in this pull request

  • Update DSI configuration in terraform/application/config/sandbox_app_env.yml to point to production DSI.
  • Add "sandbox" domains to Production DSI configuration.
  • Sandbox DSI secret has been added to the key vault.

Guidance to review

Considerations

  • External APIs should be read-only.
  • Writing to external partners, such as ESFA, should be configured to not go to actual external partners.

@Nitemaeric Nitemaeric self-assigned this Sep 25, 2024
@Nitemaeric Nitemaeric added the deploy A Review App will be created for PRs with this label label Sep 25, 2024
@Nitemaeric Nitemaeric marked this pull request as ready for review September 25, 2024 13:42
@Nitemaeric Nitemaeric requested review from a team as code owners September 25, 2024 13:42
Copy link

Copy link
Member

@ollietreend ollietreend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writing to external partners, such as ESFA, should be configured to not go to actual external partners.

Is this already the case? Or does that need adding to this PR?

I'm also wondering about integrations like GOV.UK Notify. Will that send real-world emails to users, or are they caught?

@Nitemaeric
Copy link
Contributor Author

Writing to external partners, such as ESFA, should be configured to not go to actual external partners.

Is this already the case? Or does that need adding to this PR?

I'm also wondering about integrations like GOV.UK Notify. Will that send real-world emails to users, or are they caught?

Sorry, didn't realise you responded to this.

It's the case for ESFA, where we don't want actual payments to go through. I'd assume things like, updating mentor TRNs and others, we wouldn't want to really be updated either.

That being said, I think emails are still important to actually be sent. This is because, we want the ability to invite users onto the sandbox platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants