Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jc/re add provider id to placements route #1079

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

JamieCleare2525
Copy link
Contributor

Context

Change the namespace for the provider view of placements to within provider/:provider_id

Changes proposed in this pull request

  • Moving the provider placements routes within the provider namespace
  • Add a provider param and rename the placements_placements_path to placements_providers_placements_path(:provider_id) across service
  • Move placements controller and views into the provider directory

Guidance to review

  • Sign in as Patricia (Provider User)
  • This should take you to the placements page.
  • All placements index and show pages should function as normal

Link to Trello card

https://trello.com/c/4RkwDbBA/852-refactor-placement-routes-so-the-provider-id-is-included-in-the-url-path

Screenshots

Screenshot 2024-10-03 at 16 03 47

@JamieCleare2525 JamieCleare2525 added the deploy A Review App will be created for PRs with this label label Oct 3, 2024
@JamieCleare2525 JamieCleare2525 self-assigned this Oct 3, 2024
@JamieCleare2525 JamieCleare2525 requested review from a team as code owners October 3, 2024 15:04
Copy link

github-actions bot commented Oct 3, 2024

Review app track and pay deployed to https://track-and-pay-1079.test.teacherservices.cloud was deleted
Review app school placements deployed to https://manage-school-placements-1079.test.teacherservices.cloud was deleted

@JamieCleare2525 JamieCleare2525 merged commit 7fdb2e9 into main Oct 4, 2024
8 checks passed
@JamieCleare2525 JamieCleare2525 deleted the jc/re-add_provider_id_to_placements_route branch October 4, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants