Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove current organisation #1082

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Remove current organisation #1082

merged 2 commits into from
Oct 7, 2024

Conversation

JamieCleare2525
Copy link
Contributor

Context

  • Remove the concept of current_organisation throughout the service

Changes proposed in this pull request

  • Remove current_organisation attribute from user models
  • Remove current_organisation from policies

Guidance to review

  • Test most of the features of the service to ensure nothing has broken.

Link to Trello card

https://trello.com/c/onvm1r3x/853-remove-the-concept-of-the-current-user-having-a-current-organisation

@JamieCleare2525 JamieCleare2525 added the deploy A Review App will be created for PRs with this label label Oct 4, 2024
@JamieCleare2525 JamieCleare2525 self-assigned this Oct 4, 2024
@JamieCleare2525 JamieCleare2525 requested review from a team as code owners October 4, 2024 10:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024 •
edited
Loading

Review app track and pay deployed to https://track-and-pay-1082.test.teacherservices.cloud was deleted
Review app school placements deployed to https://manage-school-placements-1082.test.teacherservices.cloud was deleted

ollietreend
ollietreend reviewed Oct 7, 2024
View reviewed changes
Copy link
Member

@ollietreend ollietreend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'd benefit from restructuring the queries very slightly. But overall this is excellent work ⭐ thanks!

app/policies/placements/mentor_policy.rb Outdated Show resolved Hide resolved
app/policies/provider_policy.rb Outdated Show resolved Hide resolved
app/policies/school_policy.rb Outdated Show resolved Hide resolved
@JamieCleare2525 JamieCleare2525 merged commit 32a313d into main Oct 7, 2024
8 checks passed
@JamieCleare2525 JamieCleare2525 deleted the jc/remove_concept_of_current_organisation branch October 7, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ollietreend ollietreend ollietreend approved these changes

@Kizr Kizr Kizr approved these changes

Assignees

@JamieCleare2525 JamieCleare2525

Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamieCleare2525 @ollietreend @Kizr