Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move support user primary nav to the service header #1085

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JamieCleare2525
Copy link
Contributor

Context

  • Move Support User primary nav to the service header.

Changes proposed in this pull request

  • Add new header navigation partial for support users.
  • Replace the primary navigation for support users with navigation in the header.

Guidance to review

  • Sign in as Colin
  • Primary navigation options for Organisation, Support users, and Settings should now appear in the service header.

Link to Trello card

https://trello.com/c/R3I4rmO3/845-investigate-what-changes-will-need-to-be-made-for-the-support-console-changes

Screenshots

screencapture-bat-school-placements-18b07385d8a1-herokuapp-support-users-v2-organisation-selection-2024-10-04-17_25_38

@JamieCleare2525 JamieCleare2525 self-assigned this Oct 4, 2024
@JamieCleare2525 JamieCleare2525 requested review from a team as code owners October 4, 2024 16:26
@@ -29,7 +29,10 @@
<% header.with_product_name(name: service_name) %>

<% if current_user %>
<% header.with_navigation_item(text: t(".your_account"), href: account_path) %>
<%# header.with_navigation_item(text: t(".your_account"), href: account_path) %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be removed?

Comment on lines +1 to +7
en:
placements:
support:
header_navigation:
users: Support users
organisations: Organisations
settings: Settings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a new line to the bottom of this file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants