Refactor methods on claims mentor training form #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Nitemaeric
approved these changes
Oct 7, 2024
ollietreend
force-pushed
the
refactor-mentor-training-methods
branch
from
d35742d
to
8fe6236
Compare
I've relocated the logic that was originally defined as `Claims::Claim::MentorTrainingForm#max_hours_equals_maximum_claimable_hours?` because it was only needed and used in the component `Claims::Claim::MentorTrainingForm::DisclaimerComponent`. The component spec already covered the required behaviour, so I was able to simply move the code and cut out an unnecessary layer of abstraction.
This method doesn't need to be part of the form object's public interface, so I've made it private. It's only used by the validation rules inside this class. I've also dropped the memoization of this method. It's a simple and cheap enough method to run that I don't think it's harmful to run it twice. It simplifies the code and doesn't add any significant overhead.
This value is already memoized in the training allowance object. There's no need to double memoize it.
ollietreend
force-pushed
the
refactor-mentor-training-methods
branch
from
8fe6236
to
0f9fe17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
These changes come off the back of a comment thread in a separate PR – see #1062 (comment)
We agreed that the changes I suggested were out of scope for that PR, so I've put them into a new one.
Now that we have a standalone 'training allowance' object, it feels unnecessary for the mentor training form to hide that object from the outside world through abstractions and wrapper methods.
Changes proposed in this pull request
mentor_training_form.max_hours_equals_maximum_claimable_hours?Guidance to review
This PR is based upon #1062 for now, since that branch hasn't been merged in to main yet.
To review this PR, see the commits:
custom_hours_selected?method privateLink to Trello card
Offshoot of: Refactor the claim form to use Training Allowance