Add walking time to travel time service object #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d from object for all travel modes
dp-daly
changed the base branch from
main
to
dpd/update-placements-index-design
JamieCleare2525
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We are adding travel duration between a user's search location and placement schools which appear in search results. A service object exists with drive and transit travel modes, but a walk travel mode is also needed.
Changes proposed in this pull request
Guidance to review
Run the following travel time tests:
spec/services/placements/travel_time_spec.rbspec/lib/google/routes_api_spec.rbRun the school decorator test (modified to add walking duration as an attribute):
spec/decorators/school_decorator_spec.rbLink to Trello card
https://trello.com/c/TMFoYL9a/855-add-walking-time-to-travel-time-service-object