Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve coverage of policy scopes in controllers #1101

Open
wants to merge 1 commit into
base: jc/change_support_console_views_to_use_multi-org
Choose a base branch
from
Open

Improve coverage of policy scopes in controllers #1101

wants to merge 1 commit into from

Conversation

JamieCleare2525
Copy link
Contributor

Context

  • Improve use of policy_scope throughout the controllers.

Changes proposed in this pull request

  • Ensure all controller methods use policy_scope where possible.

Guidance to review

  • Sign in as each user type and test that all features still work as expected.

Link to Trello card

https://trello.com/c/Mi2stP5t/848-expand-and-improve-on-the-use-of-pundit-scopes

@JamieCleare2525 JamieCleare2525 added the deploy A Review App will be created for PRs with this label label Oct 10, 2024
@JamieCleare2525 JamieCleare2525 self-assigned this Oct 10, 2024
@JamieCleare2525 JamieCleare2525 requested a review from a team as a code owner October 10, 2024 08:23
@github-actions GitHub Actions
Copy link

Deployments

App URL
Track & Pay https://track-and-pay-1101.test.teacherservices.cloud
School Placements https://manage-school-placements-1101.test.teacherservices.cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kizr Kizr Kizr approved these changes

Assignees

@JamieCleare2525 JamieCleare2525

Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamieCleare2525 @Kizr